You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically while tests are in review we don't want them showing in the production site allowing us to get feedback and input from the community and framework authors.
This should be two PRs:
Add an option to the a tests config so it only shows in the docs in local builds and deployment previews not production site
Update the config that if a tests is in review to not save versions. If a framework is bumped we drop this tests from the previous version results. Tests in review often get a lot of tweaks and re-running can be time consuming
Once this pr #846 merges you can use packages/results/src/measurements-config.ts and maybe add a flag like status: live | under review.
Config is injected into the results at the end so you could access it from the results or just import the config into the docs and then take it from there
hey, i'd like to take the first part of this. plan: add status: 'live' | 'in-review' to each entry in measurements-config.ts, and hide in-review tests only when WORKERS_CI_BRANCH === 'main' so local builds and branch previews still show them. the sections on the dev/run time and framework pages are hardcoded, so i'd wrap them in a small <InReview test="..."> component. does that work, and is there a test that should start as in-review?
Activity
AlexanderKaran commentedon Nov 12, 2026
Once this pr #846 merges you can use
packages/results/src/measurements-config.tsand maybe add a flag likestatus:live|under review.Config is injected into the results at the end so you could access it from the results or just import the config into the docs and then take it from there
maksimgm commentedon Nov 20, 2026
hey, i'd like to take the first part of this. plan: add
status: 'live' | 'in-review'to each entry inmeasurements-config.ts, and hide in-review tests only whenWORKERS_CI_BRANCH === 'main'so local builds and branch previews still show them. the sections on the dev/run time and framework pages are hardcoded, so i'd wrap them in a small<InReview test="...">component. does that work, and is there a test that should start as in-review?AlexanderKaran commentedon Nov 20, 2026
@maksimgm Sounds good from a quick read. I guess we can mess with how the UI does it once its live.
Can you split the PR so change to config and change to docs are two seperate ones. :)