Skip to content

adopt dto-style structured json file for lf versions from canton to sdk#22905

Merged
roger-bosman-da merged 3 commits intomainfrom
roger/versionjson-to-dto
Apr 21, 2026
Merged

adopt dto-style structured json file for lf versions from canton to sdk#22905
roger-bosman-da merged 3 commits intomainfrom
roger/versionjson-to-dto

Conversation

@roger-bosman-da
Copy link
Copy Markdown
Contributor

No description provided.

update new structured file

add staging version
@roger-bosman-da roger-bosman-da force-pushed the roger/versionjson-to-dto branch from f43b561 to d5782dc Compare April 16, 2026 12:47
@roger-bosman-da roger-bosman-da added the no-release-notes Apply this label to skip the UNRELEASED.md modification check label Apr 16, 2026
@roger-bosman-da roger-bosman-da marked this pull request as ready for review April 16, 2026 13:07
@roger-bosman-da roger-bosman-da changed the title versionjson to dto adopt dto-style structured json file for lf versions from canton to sdk Apr 16, 2026
Copy link
Copy Markdown
Contributor

@dylant-da dylant-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor nitpicks, thank you!

"2.3-rc1",
"2.1",
"2.dev",
"2.3-rc1",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have 2.3-rc1 twice in this list? I see we still repeat it below

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a consequence of defining both "2.3" and "2.3.1" canton side. It gets deduplicated to account for this

Comment thread sdk/daml-lf/daml-lf.bzl Outdated
Comment thread sdk/daml-lf/daml-lf.bzl Outdated
Comment thread sdk/daml-lf/generate_haskell_versions.py Outdated
Comment thread sdk/daml-lf/generate_haskell_versions.py Outdated
@roger-bosman-da roger-bosman-da enabled auto-merge (squash) April 21, 2026 08:13
@roger-bosman-da roger-bosman-da merged commit 0825331 into main Apr 21, 2026
19 checks passed
@roger-bosman-da roger-bosman-da deleted the roger/versionjson-to-dto branch April 21, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release-notes Apply this label to skip the UNRELEASED.md modification check Standard-Change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants