Skip to content

[Spark] Provide default implementations for SnapshotDescriptor.dataPath, numDeltaFiles, and totalDeltaFilesByteSize #7086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huan233usc wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −3
Open

[Spark] Provide default implementations for SnapshotDescriptor.dataPath, numDeltaFiles, and totalDeltaFilesByteSize #7086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sharing/src/main/scala/io/delta/sharing/spark/DeltaSharingUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ object DeltaSharingUtils extends Logging {
localDeltaLog,
new SnapshotDescriptor {
val deltaLog: DeltaLog = localDeltaLog
val dataPath: Path = localDeltaLog.dataPath
override val dataPath: Path = localDeltaLog.dataPath
val logPath: Path = localDeltaLog.logPath
val metadata: Metadata = deltaSharingTableMetadata.metadata.deltaMetadata
val protocol: Protocol = deltaSharingTableMetadata.protocol.deltaProtocol
Expand Down
8 changes: 7 additions & 1 deletion spark/src/main/scala/org/apache/spark/sql/delta/Snapshot.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,14 @@ trait SnapshotDescriptor extends DeltaLoggingProvider {

def schema: StructType = metadata.schema

def dataPath: Path
def dataPath: Path =
throw new UnsupportedOperationException("dataPath is not implemented for this descriptor")
def logPath: Path
def numDeltaFiles: Long =
throw new UnsupportedOperationException("numDeltaFiles is not implemented for this descriptor")
def totalDeltaFilesByteSize: Long =
throw new UnsupportedOperationException(
"totalDeltaFilesByteSize is not implemented for this descriptor")

protected[delta] def numOfFilesIfKnown: Option[Long]
protected[delta] def sizeInBytesIfKnown: Option[Long]
Expand Down
2 changes: 1 addition & 1 deletion spark/src/main/scala/org/apache/spark/sql/delta/sources/DeltaSource.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ trait DeltaSourceBase extends Source
// Construct a snapshot descriptor with custom schema inline
new SnapshotDescriptor {
val deltaLog: DeltaLog = snapshotAtSourceInit.deltaLog
val dataPath: Path = snapshotAtSourceInit.dataPath
override val dataPath: Path = snapshotAtSourceInit.dataPath
val logPath: Path = snapshotAtSourceInit.logPath
val metadata: Metadata =
snapshotAtSourceInit.metadata.copy(
Expand Down
Loading