[Spark] Provide default implementations for SnapshotDescriptor.dataPath, numDeltaFiles, and totalDeltaFilesByteSize#7086
Open
huan233usc wants to merge 1 commit into
Conversation
…th, numDeltaFiles, and totalDeltaFilesByteSize SnapshotDescriptor previously declared dataPath as an abstract member, requiring every implementor to define it. Make dataPath a default implementation that throws UnsupportedOperationException, and add numDeltaFiles and totalDeltaFilesByteSize as members with the same default. Implementors that can supply these values override them; those that cannot no longer need stub overrides. The two inline descriptors that define dataPath now mark it as an override since the trait member is no longer abstract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SnapshotDescriptordeclareddataPathas an abstract member, requiring every implementor to define it. This change makesdataPatha default implementation that throwsUnsupportedOperationException, and addsnumDeltaFilesandtotalDeltaFilesByteSizeas members with the same default.Implementors that can supply these values override them; those that cannot no longer need stub overrides. The two inline
SnapshotDescriptorinstances that definedataPath(DeltaSource.readSnapshotDescriptorandDeltaSharingUtils) now mark it as anoverride, since the trait member is no longer abstract.How was this patch tested?
Existing tests. This refactors trait member declarations; the throw-default bodies preserve behavior for callers that already implement these members.
Does this PR introduce any user-facing changes?
No.