New SashimiBigWig Track v2 - #500
Open
lldelisle wants to merge 83 commits into
Open
Conversation
Collaborator
Author
|
@bgruening would you mind to also review this one which has more changes. As the SashimiBigWig Track is a mixture of bigwig and bed, I tried to move most of methods that could be reused in GenomeTracks or BigWigTracks, that is why there are so many changes. |
bgruening
reviewed
Sep 2, 2026
|
|
||
| return bed_file_h, total_length | ||
|
|
||
| def process_bed(self, default_color, file_key='file', color_key='color', plot_regions=None): |
Member
There was a problem hiding this comment.
mh, but classes like BIgWig, HiC etc don't have those defined? Maybe an intermediate class, mixin like BedLike() or something like that?
bgruening
reviewed
Sep 2, 2026
bgruening
approved these changes
Sep 2, 2026
Collaborator
Author
|
Oups, I revert the proposed change as it was raising an error: pygenometracks/tracks/SashimiBigWigTrack.py:196: in __init__
super().__init__(*args, **kwargs)
pygenometracks/tracks/BigWigTrack.py:117: in __init__
super(self.__class__, self).__init__(*args, **kwargs)
pygenometracks/tracks/BigWigTrack.py:117: in __init__
super(self.__class__, self).__init__(*args, **kwargs)
E RecursionError: maximum recursion depth exceeded
!!! Recursion detected (same locals & position) |
lldelisle
force-pushed
the
sashimi_reb
branch
from
September 3, 2026 08:51
41cb06a to
40804e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #489