fix open by default app and expose default app#2230
Merged
ishank011 merged 2 commits intocs3org:masterfrom Nov 10, 2021
wkloucek:default-app-handling
Merged
fix open by default app and expose default app#2230ishank011 merged 2 commits intocs3org:masterfrom wkloucek:default-app-handling
ishank011 merged 2 commits intocs3org:masterfrom
wkloucek:default-app-handling
Conversation
This was referenced Nov 3, 2021
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Nov 4, 2021
9 tasks
glpatcern
previously approved these changes
Nov 4, 2021
Member
glpatcern
left a comment
There was a problem hiding this comment.
Looks good, clearly having the default semantically explicit is better than just relying on the sorting of the app providers, which was definitely temporary.
At this point we could actually remove the logic to keep the app providers list ordered.
Contributor
Author
|
@glpatcern I updated the CS3apis, can we get this in? |
Member
|
(did not merge yet because I'm not code owner - will check with @ishank011 also to update the |
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Nov 4, 2021
ishank011
approved these changes
Nov 10, 2021
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Nov 10, 2021
C0rby
pushed a commit
to owncloud/ocis
that referenced
this pull request
Nov 10, 2021
kulmann
added a commit
to owncloud/ocis
that referenced
this pull request
Nov 11, 2021
[full-ci] update reva to get cs3org/reva#2230
ownclouders
pushed a commit
to owncloud/ocis
that referenced
this pull request
Nov 11, 2021
wkloucek
added a commit
to owncloud/ocis
that referenced
this pull request
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs: cs3org/cs3apis#157
needed because of owncloud/web#5970 (comment)
After this PR the
/app/listendpoint will provide a default app (if configured):{ "mime_type": "application/vnd.oasis.opendocument.text", "ext": "odt", "app_providers": [ { "name": "Collabora", "icon": "https://www.collaboraoffice.com/wp-content/uploads/2019/01/CP-icon.png" } ], "name": "OpenDocument", "description": "OpenDocument text document", "allow_creation": true, "default_application": "Collabora" }