add default_application to MimeTypeInfo#157
Merged
glpatcern merged 2 commits intocs3org:mainfrom Nov 4, 2021
wkloucek:default_application
Merged
add default_application to MimeTypeInfo#157glpatcern merged 2 commits intocs3org:mainfrom wkloucek:default_application
glpatcern merged 2 commits intocs3org:mainfrom
wkloucek:default_application
Conversation
glpatcern
approved these changes
Nov 3, 2021
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Looks good to me, can you please also apply the (unrelated) suggested change?
Co-authored-by: Giuseppe Lo Presti <giuseppe.lopresti@cern.ch>
Member
|
Thanks Willy, I don't get why the build is failing though: could you perhaps try and |
Contributor
Author
I already posted in the CS3apis Gitter channel about this. I think the changes fromhttps://github.com/cs3org/cs3apis-build/pull/18 broke it. |
Contributor
Author
|
@glpatcern CI is green now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needed by cs3org/reva#2230