Skip to content

Align metadata.generateName in Create Managed Resource Script #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbw976 merged 3 commits into from
Mar 14, 2025
Merged

Align metadata.generateName in Create Managed Resource Script #863

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaaafd2
align metadata.generateName in create managed resource script
timyip3 Jan 29, 2025
b699f5f
Merge branch 'crossplane:master' into master
timyip3 Mar 14, 2025
d83ad87
align line number with hover
timyip3 Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/master/getting-started/provider-aws.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ The {{< hover label="xr" line="3">}}apiVersion{{< /hover >}} and
{{< hover label="xr" line="4">}}kind{{</hover >}} are from the provider's CRDs.
Copy link
Copy Markdown
Member

@jbw976 jbw976 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think most of these line numbers are 1 off, maybe something got removed in the past and they weren't updated. Are you interested in updating them so that hovering over them highlights the correct line? 😇

Copy link
Copy Markdown
Contributor Author

@timyip3 timyip3 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Let me update the line number together with this PR as well!



The {{< hover label="xr" line="6">}}metadata.name{{< /hover >}} value is the
The {{< hover label="xr" line="6">}}metadata.generateName{{< /hover >}} value is the
Copy link
Copy Markdown
Member

@jbw976 jbw976 Mar 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this line="6" can also be updated to 5 so it's highlighting the right line number on hover

name of the created S3 bucket in AWS.
This example uses the generated name `crossplane-bucket-<hash>` in the
{{< hover label="xr" line="6">}}$bucket{{</hover >}} variable.
Expand Down