Align metadata.generateName in Create Managed Resource Script#863
Align metadata.generateName in Create Managed Resource Script#863jbw976 merged 3 commits intocrossplane:masterfrom
Conversation
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Timothy Yip <timyip3@gmail.com>
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
Thank you @timyip3 for providing this update! There's a bit more that could be done for completeness with the line numbers, let me know if you don't want to take those on also in this PR. If you're not up for it then we can merge this fix as is because it does make progress 😉
|
|
||
|
|
||
| The {{< hover label="xr" line="6">}}metadata.name{{< /hover >}} value is the | ||
| The {{< hover label="xr" line="6">}}metadata.generateName{{< /hover >}} value is the |
There was a problem hiding this comment.
i think this line="6" can also be updated to 5 so it's highlighting the right line number on hover
| @@ -201,7 +201,7 @@ The {{< hover label="xr" line="3">}}apiVersion{{< /hover >}} and | |||
| {{< hover label="xr" line="4">}}kind{{</hover >}} are from the provider's CRDs. | |||
There was a problem hiding this comment.
i think most of these line numbers are 1 off, maybe something got removed in the past and they weren't updated. Are you interested in updating them so that hovering over them highlights the correct line? 😇
There was a problem hiding this comment.
Thanks for the review! Let me update the line number together with this PR as well!
Signed-off-by: Timothy Yip <timyip3@gmail.com>
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
Awesome, this looks good on the preview site now, so let's go ahead and merge! thanks for also taking care of the line numbers @timyip3! 🙇♂️
2 participants
No description provided.