Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/lint-workflows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ jobs:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
with:
persist-credentials: false
- uses: kjanat/actionlint@08bb2c4f0d039744455b87aef1c647fb8b66d37b # v1.17.0
- uses: raven-actions/actionlint@3d39aea434753780c3b3d4a1a31c854b4dbf49d7 # v2.2.0
with:
version: 1.7.12 # actionlint binary; the action otherwise downloads latest

zizmor:
name: zizmor
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ on:
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}
queue: max
group: ${{ github.workflow }}-${{ github.ref }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Removing queue: max leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite cancel-in-progress: false. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/release.yml, line 10:

<comment>Removing `queue: max` leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite `cancel-in-progress: false`. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.</comment>

<file context>
@@ -7,8 +7,7 @@ on:
 concurrency:
-  group: ${{ github.workflow }}
-  queue: max
+  group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: false
 
</file context>

cancel-in-progress: false

permissions: {}
Expand Down Expand Up @@ -39,9 +38,9 @@ jobs:
node-version: ${{ env.NODE_VERSION }}
package-manager-cache: false
- id: release
uses: convex/npm-release-actions/validate-tag@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
uses: convex/npm-release-actions/validate-tag@3a142e21f421319890981579b8952267bc11fc53 # v0.3.0
- run: npm ci
- uses: convex/npm-release-actions/check-release-notes@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
- uses: convex/npm-release-actions/check-release-notes@3a142e21f421319890981579b8952267bc11fc53 # v0.3.0
- run: npm run build
- run: npm run check
- name: Run E2E tests and verify generated code
Expand All @@ -53,7 +52,7 @@ jobs:
git diff --exit-code -- src/component/_generated
test -z "$(git ls-files --others --exclude-standard src/component/_generated)"
- id: pack
uses: convex/npm-release-actions/pack@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
uses: convex/npm-release-actions/pack@3a142e21f421319890981579b8952267bc11fc53 # v0.3.0

stage:
needs: build
Expand All @@ -63,7 +62,7 @@ jobs:
contents: read
id-token: write
steps:
- uses: convex/npm-release-actions/stage@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
- uses: convex/npm-release-actions/stage@3a142e21f421319890981579b8952267bc11fc53 # v0.3.0
with:
artifact-id: ${{ needs.build.outputs.artifact_id }}
sha256: ${{ needs.build.outputs.sha256 }}
Expand Down
7 changes: 3 additions & 4 deletions .github/workflows/version.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Update release PR

concurrency:
group: ${{ github.workflow }}
queue: max
group: ${{ github.workflow }}-${{ github.sha }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Removing queue: max lets a later same-commit dispatch cancel an earlier pending version run, because cancel-in-progress: false does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/version.yml, line 4:

<comment>Removing `queue: max` lets a later same-commit dispatch cancel an earlier pending version run, because `cancel-in-progress: false` does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.</comment>

<file context>
@@ -1,8 +1,7 @@
 concurrency:
-  group: ${{ github.workflow }}
-  queue: max
+  group: ${{ github.workflow }}-${{ github.sha }}
   cancel-in-progress: false
 
</file context>

cancel-in-progress: false

on:
Expand Down Expand Up @@ -32,7 +31,7 @@ jobs:
node-version: "24.22.1"
package-manager-cache: false
- run: npm ci --ignore-scripts
- uses: convex/npm-release-actions/version-pr@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
- uses: convex/npm-release-actions/version-pr@3a142e21f421319890981579b8952267bc11fc53 # v0.3.0

tag:
name: Tag a new version
Expand All @@ -48,4 +47,4 @@ jobs:
ref: ${{ github.sha }}
fetch-depth: 0
persist-credentials: false
- uses: convex/npm-release-actions/tag-version@6d8758603978f892ffbdcd1a170b8b0c121efefe # v0.2.0
- uses: convex/npm-release-actions/tag-version@3a142e21f421319890981579b8952267bc11fc53 # v0.3.0
Loading