Repository navigation
Drop concurrency queues and use upstream actionlint - #294
Merged
Merged
Conversation
Group Release runs per tag and version workflow runs per commit instead of queueing them, lint with raven-actions/actionlint instead of the kjanat wrapper (needed only for queue), and pin npm-release-actions v0.3.0, which tolerates two runs creating the same tag.
commit: |
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/release.yml">
<violation number="1" location=".github/workflows/release.yml:10">
P2: Removing `queue: max` leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite `cancel-in-progress: false`. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.</violation>
</file>
<file name=".github/workflows/version.yml">
<violation number="1" location=".github/workflows/version.yml:4">
P2: Removing `queue: max` lets a later same-commit dispatch cancel an earlier pending version run, because `cancel-in-progress: false` does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| concurrency: | ||
| group: ${{ github.workflow }} | ||
| queue: max | ||
| group: ${{ github.workflow }}-${{ github.ref }} |
There was a problem hiding this comment.
P2: Removing queue: max leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite cancel-in-progress: false. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/release.yml, line 10:
<comment>Removing `queue: max` leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite `cancel-in-progress: false`. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.</comment>
<file context>
@@ -7,8 +7,7 @@ on:
concurrency:
- group: ${{ github.workflow }}
- queue: max
+ group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false
</file context>
| concurrency: | ||
| group: ${{ github.workflow }} | ||
| queue: max | ||
| group: ${{ github.workflow }}-${{ github.sha }} |
There was a problem hiding this comment.
P2: Removing queue: max lets a later same-commit dispatch cancel an earlier pending version run, because cancel-in-progress: false does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/version.yml, line 4:
<comment>Removing `queue: max` lets a later same-commit dispatch cancel an earlier pending version run, because `cancel-in-progress: false` does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.</comment>
<file context>
@@ -1,8 +1,7 @@
concurrency:
- group: ${{ github.workflow }}
- queue: max
+ group: ${{ github.workflow }}-${{ github.sha }}
cancel-in-progress: false
</file context>
raven-actions/actionlint downloads the latest actionlint unless version is set, so pinning the action's commit alone doesn't pin the linter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
concurrency.queue. Runs for different tags or commits never cancel each other. A newer run for the same tag or commit (a duplicate dispatch, or a moved tag) replaces an older pending one, which is equivalent or the one we want.version-prskips runs whose commit is no longermain's tip, andtag-version(v0.3.0) accepts a tag another run just created on the same commit.raven-actions/actionlint(upstream actionlint), replacing thekjanat/actionlintwrapper, which was needed only forqueuesupport. The actionlint binary is pinned to 1.7.12, since the action otherwise downloads the latest release.convex/npm-release-actionsto v0.3.0.