Skip to content

Drop concurrency queues and use upstream actionlint - #294

Merged
ianmacartney merged 2 commits into
mainfrom
ian/drop-concurrency-queue
Nov 18, 2026
Merged

ianmacartney merged 2 commits into
mainfrom
ian/drop-concurrency-queue

Conversation

@ianmacartney

@ianmacartney ianmacartney commented Nov 18, 2026 •

Copy link
Copy Markdown
Member
  • Release runs are grouped per tag and the version workflow per commit, without concurrency.queue. Runs for different tags or commits never cancel each other. A newer run for the same tag or commit (a duplicate dispatch, or a moved tag) replaces an older pending one, which is equivalent or the one we want. version-pr skips runs whose commit is no longer main's tip, and tag-version (v0.3.0) accepts a tag another run just created on the same commit.
  • Workflow linting uses raven-actions/actionlint (upstream actionlint), replacing the kjanat/actionlint wrapper, which was needed only for queue support. The actionlint binary is pinned to 1.7.12, since the action otherwise downloads the latest release.
  • Pins convex/npm-release-actions to v0.3.0.

Group Release runs per tag and version workflow runs per commit instead of
queueing them, lint with raven-actions/actionlint instead of the kjanat
wrapper (needed only for queue), and pin npm-release-actions v0.3.0, which
tolerates two runs creating the same tag.
@pkg-pr-new

pkg-pr-new Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@convex-dev/aggregate@294

commit: 3d6572d

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/release.yml">

<violation number="1" location=".github/workflows/release.yml:10">
P2: Removing `queue: max` leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite `cancel-in-progress: false`. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.</violation>
</file>

<file name=".github/workflows/version.yml">

<violation number="1" location=".github/workflows/version.yml:4">
P2: Removing `queue: max` lets a later same-commit dispatch cancel an earlier pending version run, because `cancel-in-progress: false` does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

concurrency:
group: ${{ github.workflow }}
queue: max
group: ${{ github.workflow }}-${{ github.ref }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Removing queue: max leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite cancel-in-progress: false. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/release.yml, line 10:

<comment>Removing `queue: max` leaves only one pending same-tag run, so a later manual retry cancels an earlier pending retry despite `cancel-in-progress: false`. Preserve a real queue for same-tag runs, or use another mechanism that retains retries while serializing releases.</comment>

<file context>
@@ -7,8 +7,7 @@ on:
 concurrency:
-  group: ${{ github.workflow }}
-  queue: max
+  group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: false
 
</file context>

concurrency:
group: ${{ github.workflow }}
queue: max
group: ${{ github.workflow }}-${{ github.sha }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Removing queue: max lets a later same-commit dispatch cancel an earlier pending version run, because cancel-in-progress: false does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At .github/workflows/version.yml, line 4:

<comment>Removing `queue: max` lets a later same-commit dispatch cancel an earlier pending version run, because `cancel-in-progress: false` does not preserve pending runs. Keep all same-commit attempts queued or otherwise avoid dropping them.</comment>

<file context>
@@ -1,8 +1,7 @@
 concurrency:
-  group: ${{ github.workflow }}
-  queue: max
+  group: ${{ github.workflow }}-${{ github.sha }}
   cancel-in-progress: false
 
</file context>

raven-actions/actionlint downloads the latest actionlint unless version is
set, so pinning the action's commit alone doesn't pin the linter.
@ianmacartney
ianmacartney merged commit f8d5a18 into main Nov 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant