-
Notifications
You must be signed in to change notification settings - Fork 1k
Capture cpu profile for keynote bench in nightly job #5163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joshua-spacetime
wants to merge
2
commits into
master
Choose a base branch
from
joshua/samply-keynote-bench
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−2
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| name: Keynote Bench Nightly | ||
|
|
||
| on: | ||
| schedule: | ||
| # Nightly at 3 AM UTC. | ||
| - cron: '0 3 * * *' | ||
| workflow_dispatch: | ||
| inputs: | ||
| ref: | ||
| description: "Git ref to benchmark" | ||
| required: false | ||
| default: master | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: keynote-bench-nightly | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| keynote_bench: | ||
| name: Keynote Bench | ||
| runs-on: spacetimedb-benchmark-runner | ||
| timeout-minutes: 60 | ||
| env: | ||
| CARGO_TARGET_DIR: ${{ github.workspace }}/target | ||
| CARGO_PROFILE_RELEASE_DEBUG: line-tables-only | ||
| KEYNOTE_PROFILE_DIR: ${{ github.workspace }}/keynote-profile | ||
| STDB_V8_FLAGS: "--perf-basic-prof --perf-basic-prof-only-functions --interpreted-frames-native-stack" | ||
| steps: | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.inputs.ref || 'master' }} | ||
|
|
||
| - uses: dsherret/rust-toolchain-file@v1 | ||
| - name: Set default rust toolchain | ||
| run: rustup default $(rustup show active-toolchain | cut -d' ' -f1) | ||
|
|
||
| - name: Cache Rust dependencies | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| workspaces: ${{ github.workspace }} | ||
| shared-key: spacetimedb | ||
| save-if: false | ||
| prefix-key: v1 | ||
|
|
||
| - name: Build keynote benchmark binaries | ||
| run: > | ||
| cargo | ||
| --config 'build.rustflags = ["-C", "force-frame-pointers=yes"]' | ||
| build | ||
| --release | ||
| -p spacetimedb-cli | ||
| -p spacetimedb-standalone | ||
| --features spacetimedb-standalone/perfmap | ||
|
|
||
| # Node 24 is the current Active LTS line. | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 24 | ||
|
|
||
| - uses: ./.github/actions/setup-pnpm | ||
| with: | ||
| run_install: true | ||
|
|
||
| - name: Build TypeScript SDK | ||
| run: pnpm build | ||
| working-directory: crates/bindings-typescript | ||
|
|
||
| - name: Run keynote-2 benchmark regression check | ||
| id: keynote_bench | ||
| run: | | ||
| mkdir -p "$KEYNOTE_PROFILE_DIR" | ||
| samply record \ | ||
| --save-only \ | ||
| --unstable-presymbolicate \ | ||
| --profile-name keynote-bench-nightly \ | ||
| -o "$KEYNOTE_PROFILE_DIR/profile.json.gz" \ | ||
| -- cargo ci keynote-bench | ||
| ls -lh "$KEYNOTE_PROFILE_DIR" || true | ||
|
|
||
| - name: Upload keynote benchmark profile | ||
| if: always() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: keynote-bench-nightly-profile | ||
| path: ${{ env.KEYNOTE_PROFILE_DIR }} | ||
| if-no-files-found: warn | ||
| retention-days: 90 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note for @jdetter: I'm not sure if or how much of an impact this will have on our github actions spend. Happy to reconfigure this. I would just like some level of cpu profile history for diagnostic purposes. |
||
|
|
||
| - name: Report keynote benchmark profile instructions | ||
| if: failure() && steps.keynote_bench.outcome == 'failure' | ||
| run: | | ||
| { | ||
| echo "## Keynote benchmark profile" | ||
| echo | ||
| echo "The nightly keynote benchmark failed after recording a Samply/Firefox profile." | ||
| echo | ||
| echo "1. Open this run's Summary page: ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID}" | ||
| echo "2. Download the artifact named \`keynote-bench-nightly-profile\`." | ||
| echo "3. Open <https://profiler.firefox.com/> and load \`profile.json.gz\`." | ||
| echo "4. Compare hot frames against earlier nightly \`keynote-bench-nightly-profile\` artifacts." | ||
| } >> "$GITHUB_STEP_SUMMARY" | ||
|
|
||
| echo "::error title=Keynote benchmark profile uploaded::Download the keynote-bench-nightly-profile artifact from this run and open profile.json.gz in https://profiler.firefox.com/." | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.