Capture cpu profile for keynote bench in nightly job#5163
Open
joshua-spacetime wants to merge 1 commit into
Open
Capture cpu profile for keynote bench in nightly job#5163joshua-spacetime wants to merge 1 commit into
joshua-spacetime wants to merge 1 commit into
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
joshua-spacetime
commented
Jun 2, 2026
| run: pnpm build | ||
| working-directory: crates/bindings-typescript | ||
|
|
||
| - name: Install samply |
Contributor
Author
There was a problem hiding this comment.
TODO: This should be installed at the infra level - not by the test every time.
joshua-spacetime
commented
Jun 2, 2026
| run: | | ||
| mkdir -p "$KEYNOTE_PROFILE_DIR" | ||
| set +e | ||
| samply record \ |
Contributor
Author
There was a problem hiding this comment.
TODO: Need to set /proc/sys/kernel/perf_event_paranoid to 1 in the runner in order to give samply access to kernel-level perf events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Also capture a cpu profile on a keynote bench job failure.
API and ABI breaking changes
N/A
Expected complexity level and risk
2
Testing