[bugfix] keep track of current tray icon state#1158
Open
AlexanderYastrebov wants to merge 1 commit intocjpais:mainfrom
Open
[bugfix] keep track of current tray icon state#1158AlexanderYastrebov wants to merge 1 commit intocjpais:mainfrom
AlexanderYastrebov wants to merge 1 commit intocjpais:mainfrom
Conversation
Callers of update_tray_menu previusly required to pass tray icon state which in case of "model-state-changed" listener resulted in a bug that menu was reset to idle when transcription started for the first time. This change stores tray item state in the app and modifies update_tray_menu to use it such that callers do not need to pass the state.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before Submitting This PR
Please confirm you have done the following:
If this is a feature or change that was previously closed/rejected:
Human Written Description
Callers of update_tray_menu previusly required to pass tray icon state which in case of "model-state-changed" listener resulted in a bug that menu was reset to idle when transcription started for the first time.
This change stores tray item state in the app and modifies update_tray_menu to use it such that callers do not need to pass the state.
Related Issues/Discussions
Fixes #
Discussion:
Community Feedback
Testing
Screenshots/Videos (if applicable)
Running transcription for the first time resulted in idle-state menu:
After the fix:
AI Assistance
If AI was used: