Skip to content

[bugfix] keep track of current tray icon state#1158

Open
AlexanderYastrebov wants to merge 1 commit intocjpais:mainfrom
AlexanderYastrebov:current-tray-icon-state
Open

[bugfix] keep track of current tray icon state#1158
AlexanderYastrebov wants to merge 1 commit intocjpais:mainfrom
AlexanderYastrebov:current-tray-icon-state

Conversation

@AlexanderYastrebov
Copy link
Copy Markdown
Contributor

@AlexanderYastrebov AlexanderYastrebov commented Mar 27, 2026

Before Submitting This PR

Please confirm you have done the following:

If this is a feature or change that was previously closed/rejected:

  • I have explained in the description below why this should be reconsidered
  • I have gathered community feedback (link to discussion below)

Human Written Description

Callers of update_tray_menu previusly required to pass tray icon state which in case of "model-state-changed" listener resulted in a bug that menu was reset to idle when transcription started for the first time.

This change stores tray item state in the app and modifies update_tray_menu to use it such that callers do not need to pass the state.

Related Issues/Discussions

Fixes #
Discussion:

Community Feedback

Testing

Screenshots/Videos (if applicable)

Running transcription for the first time resulted in idle-state menu:

before

After the fix:

after

AI Assistance

  • No AI was used in this PR
  • AI was used (please describe below)

If AI was used:

  • Tools used: Copilot with Claude Sonnet 4.6
  • How extensively: debugging, explain rust copy/borrowing semantics

Callers of update_tray_menu previusly required to pass tray icon state
which in case of "model-state-changed" listener resulted in a bug that
menu was reset to idle when transcription started for the first time.

This change stores tray item state in the app and modifies update_tray_menu
to use it such that callers do not need to pass the state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant