-
Notifications
You must be signed in to change notification settings - Fork 399
Fix wording: NGTS stands for Security, not Services #2140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maelvls
wants to merge
1
commit into
cert-manager:release-next
Choose a base branch
from
maelvls:fix-wording
base: release-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -5,9 +5,10 @@ description: 'cert-manager configuration: CyberArk Issuers' | |||||||||
|
|
||||||||||
| ## Introduction | ||||||||||
|
|
||||||||||
| The CyberArk `Issuer` obtains certificates from | ||||||||||
| [CyberArk Certificate Manager](https://www.cyberark.com/products/certificate-manager/) SaaS or Self-Hosted, | ||||||||||
| or from [Palo Alto Networks Next Generation Trust Services (NGTS)](https://www.paloaltonetworks.com/sase). | ||||||||||
| The CyberArk `Issuer` obtains certificates from [CyberArk Certificate | ||||||||||
| Manager](https://www.cyberark.com/products/certificate-manager/) SaaS or | ||||||||||
| Self-Hosted, or from [Palo Alto Networks Next-Generation Trust Security | ||||||||||
| (NGTS)][ngts]. | ||||||||||
|
|
||||||||||
| The `Issuer` was formerly known as the Venafi `Issuer`, and for backwards compatibility reasons is configured using older product names - "Venafi Cloud" corresponds to CyberArk Certificate Manager SaaS and "Venafi TPP" corresponds to CyberArk Certificate Manager Self-Hosted. | ||||||||||
|
|
||||||||||
|
|
@@ -283,12 +284,14 @@ You are now ready to issue certificates using the newly provisioned CyberArk | |||||||||
| Read the [Requesting Certificates](../usage/certificate.md) document for | ||||||||||
| more information on how to create Certificate resources. | ||||||||||
|
|
||||||||||
| ## Creating an Issuer for Palo Alto Networks Next Generation Trust Services | ||||||||||
| ## Creating an Issuer for Palo Alto Networks Next-Generation Trust Security | ||||||||||
|
|
||||||||||
| The CyberArk `Issuer` supports [Palo Alto Networks Next Generation Trust | ||||||||||
| Services (NGTS)](https://www.paloaltonetworks.com/sase), a cloud-native | ||||||||||
| certificate management platform. Authentication uses OAuth 2.0 Client | ||||||||||
| Credentials, so no API key or username/password is required. | ||||||||||
| The CyberArk `Issuer` supports [Palo Alto Networks Next-Generation Trust | ||||||||||
| Security (NGTS)][ngts], a cloud-native certificate management platform. | ||||||||||
| Authentication uses OAuth 2.0 Client Credentials, so no API key or | ||||||||||
| username/password is required. | ||||||||||
|
|
||||||||||
| [ngts]: https://www.paloaltonetworks.com/network-security/next-gen-trust-security | ||||||||||
|
|
||||||||||
| In order to set up an NGTS `Issuer`, you must first create a Kubernetes | ||||||||||
| `Secret` resource containing your OAuth 2.0 client credentials. The secret | ||||||||||
|
|
@@ -317,7 +320,7 @@ or `ClusterIssuer` resource. If you are creating a `ClusterIssuer` resource, | |||||||||
| you must change the `kind` field to `ClusterIssuer` and remove the | ||||||||||
| `metadata.namespace` field. | ||||||||||
|
|
||||||||||
| The `zone` is the name of the Certificate Issuing Template (CIT) in NGTS that will be used to issue certificates. Unlike CyberArk Certificate Manager SaaS, NGTS does not use an Application prefix — the zone is just the CIT name. | ||||||||||
| The `zone` is the name of the Certificate Issuing Template (CIT) in NGTS that will be used to issue certificates. Unlike CyberArk Certificate Manager SaaS which requires both an Application name and CIT alias in the format `Application\CIT`, NGTS only requires the CIT name. | ||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I'm not sure if this is clearer. I imagine that most users will skip straight to the NGTS section and may have no knowledge of how CM-SaaS zones are configured....unless they're migrating. |
||||||||||
|
|
||||||||||
| Save the below content after making your amendments to a file named | ||||||||||
| `issuer.yaml`. | ||||||||||
|
|
||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd drop that last part, personally. It seems unnecessary. Why would the user think that an API key or u/p ARE required?