Fix wording: NGTS stands for Security, not Services#2140
Conversation
cert-manager-prow
Bot
added
dco-signoff: yes
cert-manager-prow
Bot
added
size/XS
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the Venafi/CyberArk Issuer documentation to correct the expansion of “NGTS” from “Next Generation Trust Services” to “Next-Generation Trust Security”.
Changes:
- Renames “Next Generation Trust Services” → “Next-Generation Trust Security” in the intro reference.
- Renames the NGTS section heading and link text to use “Trust Security”.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Maël Valais <mael@vls.dev>
cert-manager-prow
Bot
added
size/S
| Authentication uses OAuth 2.0 Client Credentials, so no API key or | ||
| username/password is required. |
There was a problem hiding this comment.
| Authentication uses OAuth 2.0 Client Credentials, so no API key or | |
| username/password is required. | |
| Authentication uses OAuth 2.0 Client Credentials. |
I'd drop that last part, personally. It seems unnecessary. Why would the user think that an API key or u/p ARE required?
| `metadata.namespace` field. | ||
|
|
||
| The `zone` is the name of the Certificate Issuing Template (CIT) in NGTS that will be used to issue certificates. Unlike CyberArk Certificate Manager SaaS, NGTS does not use an Application prefix — the zone is just the CIT name. | ||
| The `zone` is the name of the Certificate Issuing Template (CIT) in NGTS that will be used to issue certificates. Unlike CyberArk Certificate Manager SaaS which requires both an Application name and CIT alias in the format `Application\CIT`, NGTS only requires the CIT name. |
There was a problem hiding this comment.
| The `zone` is the name of the Certificate Issuing Template (CIT) in NGTS that will be used to issue certificates. Unlike CyberArk Certificate Manager SaaS which requires both an Application name and CIT alias in the format `Application\CIT`, NGTS only requires the CIT name. | |
| For NGTS, the `zone` is **only** the name of the Certificate Issuing Template (CIT), that will be used to issue certificates. | |
| > ℹ️ If you are migrating from CyberArk Certificate Manager SaaS or Venafi Cloud, notice that `zone` has a different format. Zone MUST be `CIT`, NOT `Application\CIT`. |
I'm not sure if this is clearer. I imagine that most users will skip straight to the NGTS section and may have no knowledge of how CM-SaaS zones are configured....unless they're migrating.
cert-manager-prow
Bot
added
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj, wallrj-cyberark The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
Bot
added
the
approved
#2114 documented "NGTS" as "Next Generation Trust Services". As pointed out by Ben, it's "Security", not "Services".
The link to SASE is also wrong, it should point to NGTS instead (https://www.paloaltonetworks.com/network-security/next-gen-trust-security).