Flask: refactor email functionality into Mailer class - #1155
Open
kevinlul wants to merge 5 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
+ Coverage 69.24% 69.34% +0.09%
==========================================
Files 25 26 +1
Lines 3239 3256 +17
==========================================
+ Hits 2243 2258 +15
- Misses 996 998 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
kevinlul
force-pushed
the
kevinlul/mailer-subclass
branch
from
June 10, 2022 16:18
5904791 to
b44fb2c
Compare
kevinlul
commented
Jun 10, 2022
kevinlul
marked this pull request as ready for review
June 22, 2022 16:09
Contributor
Author
|
Now fixed, though this specific use case is no longer needed with exome automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #1153 and has that merged in already
This is not urgently needed functionality and can be looked at another time.