Skip to content

Flask: refactor email functionality into Mailer class - #1155

Open
kevinlul wants to merge 5 commits into
masterfrom
kevinlul/mailer-subclass
Open

Flask: refactor email functionality into Mailer class#1155
kevinlul wants to merge 5 commits into
masterfrom
kevinlul/mailer-subclass

Conversation

@kevinlul

Copy link
Copy Markdown
Contributor

Requires #1153 and has that merged in already

This is not urgently needed functionality and can be looked at another time.

@kevinlul
kevinlul requested a review from frewmack June 10, 2022 14:25
@github-actions github-actions Bot added backend Flask database Entity models for SQLAlchemy and migrations tests pytest (backend) or jest (frontend) labels Jun 10, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1155 (5904791) into master (d02010b) will increase coverage by 0.09%.
The diff coverage is 68.77%.

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
+ Coverage   69.24%   69.34%   +0.09%     
==========================================
  Files          25       26       +1     
  Lines        3239     3256      +17     
==========================================
+ Hits         2243     2258      +15     
- Misses        996      998       +2     
Flag Coverage Δ
pytest 69.34% <68.77%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask/app/madmin.py 97.56% <ø> (-0.03%) ⬇️
flask/app/schemas.py 100.00% <ø> (ø)
flask/app/email.py 25.86% <20.37%> (-6.06%) ⬇️
flask/app/manage.py 19.84% <40.00%> (-0.95%) ⬇️
flask/app/blueprints/misc.py 69.93% <50.00%> (ø)
flask/app/login.py 56.41% <56.41%> (ø)
flask/app/stager.py 88.37% <88.37%> (ø)
flask/app/__init__.py 55.88% <100.00%> (-15.55%) ⬇️
flask/app/blueprints/__init__.py 100.00% <100.00%> (ø)
flask/app/blueprints/analyses.py 71.42% <100.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02010b...5904791. Read the comment docs.

@kevinlul
kevinlul force-pushed the kevinlul/mailer-subclass branch from 5904791 to b44fb2c Compare June 10, 2022 16:18
@github-actions github-actions Bot removed database Entity models for SQLAlchemy and migrations tests pytest (backend) or jest (frontend) labels Jun 10, 2022
Comment thread flask/app/stager.py Outdated
@kevinlul
kevinlul marked this pull request as ready for review June 22, 2022 16:09
@kevinlul

Copy link
Copy Markdown
Contributor Author

Now fixed, though this specific use case is no longer needed with exome automation.

@frewmack frewmack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Flask

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants