Skip to content

Flask: refactor for clarity, then regularly poll slurm for job status - #1150

Closed
kevinlul wants to merge 16 commits into
masterfrom
kevinlul/checking-job-status
Closed

Flask: refactor for clarity, then regularly poll slurm for job status#1150
kevinlul wants to merge 16 commits into
masterfrom
kevinlul/checking-job-status

Conversation

@kevinlul

@kevinlul kevinlul commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

Closes #1135

@github-actions github-actions Bot added backend Flask database Entity models for SQLAlchemy and migrations devops Docker, GitHubs Actions, CI/CD labels Jun 9, 2022
@github-actions github-actions Bot added the tests pytest (backend) or jest (frontend) label Jun 9, 2022
@codecov-commenter

codecov-commenter commented Jun 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #1150 (610c951) into master (d02010b) will decrease coverage by 0.43%.
The diff coverage is 60.97%.

@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   69.24%   68.81%   -0.44%     
==========================================
  Files          25       26       +1     
  Lines        3239     3290      +51     
==========================================
+ Hits         2243     2264      +21     
- Misses        996     1026      +30     
Flag Coverage Δ
pytest 68.81% <60.97%> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flask/app/madmin.py 97.56% <ø> (-0.03%) ⬇️
flask/app/schemas.py 100.00% <ø> (ø)
flask/app/slurm.py 22.44% <15.38%> (-15.65%) ⬇️
flask/app/email.py 25.86% <20.37%> (-6.06%) ⬇️
flask/app/manage.py 19.84% <40.00%> (-0.95%) ⬇️
flask/app/blueprints/misc.py 69.93% <50.00%> (ø)
flask/app/login.py 56.41% <56.41%> (ø)
flask/app/stager.py 81.81% <81.81%> (ø)
flask/app/__init__.py 53.57% <100.00%> (-17.86%) ⬇️
flask/app/blueprints/__init__.py 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02010b...610c951. Read the comment docs.

@kevinlul
kevinlul requested a review from frewmack June 9, 2022 20:03
@kevinlul
kevinlul marked this pull request as ready for review June 9, 2022 21:20
@kevinlul

kevinlul commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

Tomorrow, this will be broken up into several PRs:

  • timezone + configuration refactor
  • blueprints subdirectory
  • StagerLoginManager
  • Stager Flask app subclass
  • Mailer class
  • Scheduler initialization + poll_slurm implementation

@kevinlul

Copy link
Copy Markdown
Contributor Author

Broken up into #1151 #1152 #1153 #1154 #1155

@kevinlul kevinlul closed this Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Flask database Entity models for SQLAlchemy and migrations devops Docker, GitHubs Actions, CI/CD tests pytest (backend) or jest (frontend)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read job status from Slurm, move BackgroundScheduler to gunicorn master process

2 participants