enable jest/no-alias-methods

.github/renovate.json5

@@ -69,6 +69,7 @@
         "eslint-config-prettier",
         "eslint-import-resolver-typescript",
         "eslint-plugin-import",
+        "eslint-plugin-jest",
         "eslint-plugin-rxjs-angular",
         "eslint-plugin-rxjs",
         "eslint-plugin-storybook",
@@ -391,6 +392,7 @@
         "eslint-config-prettier",
         "eslint-import-resolver-typescript",
         "eslint-plugin-import",
+        "eslint-plugin-jest",
         "eslint-plugin-rxjs-angular",
         "eslint-plugin-rxjs",
         "eslint-plugin-storybook",

apps/browser/src/auth/popup/account-switching/services/account-switcher.service.spec.ts

@@ -177,7 +177,7 @@ describe("AccountSwitcherService", () => {
 
       expect(messagingService.send).toHaveBeenCalledWith("switchAccount", { userId: null });
 
-      expect(removeListenerSpy).toBeCalledTimes(1);
+      expect(removeListenerSpy).toHaveBeenCalledTimes(1);
     });
 
     it("initiates an account switch with an account id", async () => {
@@ -199,13 +199,13 @@ describe("AccountSwitcherService", () => {
       await selectAccountPromise;
 
       expect(messagingService.send).toHaveBeenCalledWith("switchAccount", { userId: "1" });
-      expect(messagingService.send).toBeCalledWith(
+      expect(messagingService.send).toHaveBeenCalledWith(
         "switchAccount",
         matches((payload) => {
           return payload.userId === "1";
         }),
       );
-      expect(removeListenerSpy).toBeCalledTimes(1);
+      expect(removeListenerSpy).toHaveBeenCalledTimes(1);
     });
   });
 });

apps/browser/src/autofill/background/auto-submit-login.background.spec.ts

@@ -130,9 +130,12 @@ describe("AutoSubmitLoginBackground", () => {
           url: validAutoSubmitUrl,
           tabId: webRequestDetails.tabId,
         });
-        expect(chrome.webNavigation.onCompleted.addListener).toBeCalledWith(expect.any(Function), {
-          url: [{ hostEquals: validAutoSubmitHost }],
-        });
+        expect(chrome.webNavigation.onCompleted.addListener).toHaveBeenCalledWith(
+          expect.any(Function),
+          {
+            url: [{ hostEquals: validAutoSubmitHost }],
+          },
+        );
       });
 
       it("sets up the auto-submit workflow when the web request occurs in a sub frame and the initiator of the request is a valid auto-submit host", async () => {
@@ -145,9 +148,12 @@ describe("AutoSubmitLoginBackground", () => {
 
         triggerWebRequestOnBeforeRequestEvent(webRequestDetails);
 
-        expect(chrome.webNavigation.onCompleted.addListener).toBeCalledWith(expect.any(Function), {
-          url: [{ hostEquals: subFrameHost }],
-        });
+        expect(chrome.webNavigation.onCompleted.addListener).toHaveBeenCalledWith(
+          expect.any(Function),
+          {
+            url: [{ hostEquals: subFrameHost }],
+          },
+        );
       });
 
       describe("injecting the auto-submit login content script", () => {
@@ -182,7 +188,7 @@ describe("AutoSubmitLoginBackground", () => {
           triggerWebNavigationOnCompletedEvent(webNavigationDetails);
           await flushPromises();
 
-          expect(scriptInjectorService.inject).toBeCalledWith({
+          expect(scriptInjectorService.inject).toHaveBeenCalledWith({
             tabId: webRequestDetails.tabId,
             injectDetails: {
               file: "content/auto-submit-login.js",
@@ -320,7 +326,7 @@ describe("AutoSubmitLoginBackground", () => {
 
           triggerWebRequestOnBeforeRequestEvent(webRequestDetails);
 
-          expect(chrome.webNavigation.onCompleted.addListener).toBeCalledWith(
+          expect(chrome.webNavigation.onCompleted.addListener).toHaveBeenCalledWith(
             autoSubmitLoginBackground["handleAutoSubmitHostNavigationCompleted"],
             { url: [{ hostEquals: validAutoSubmitHost }] },
           );
@@ -440,9 +446,12 @@ describe("AutoSubmitLoginBackground", () => {
           }),
         );
 
-        expect(chrome.webNavigation.onCompleted.addListener).toBeCalledWith(expect.any(Function), {
-          url: [{ hostEquals: validAutoSubmitHost }],
-        });
+        expect(chrome.webNavigation.onCompleted.addListener).toHaveBeenCalledWith(
+          expect.any(Function),
+          {
+            url: [{ hostEquals: validAutoSubmitHost }],
+          },
+        );
       });
     });
 
@@ -491,7 +500,7 @@ describe("AutoSubmitLoginBackground", () => {
           sendMockExtensionMessage(message, sender);
           await flushPromises();
 
-          expect(autofillService.doAutoFillOnTab).toBeCalledWith(
+          expect(autofillService.doAutoFillOnTab).toHaveBeenCalledWith(
             [
               {
                 frameId: sender.frameId,

apps/browser/src/autofill/browser/context-menu-clicked-handler.spec.ts

@@ -195,9 +195,9 @@ describe("ContextMenuClickedHandler", () => {
     it("can generate password", async () => {
       await sut.run(createData(GENERATE_PASSWORD_ID), { id: 5 } as any);
 
-      expect(generatePasswordToClipboard).toBeCalledTimes(1);
+      expect(generatePasswordToClipboard).toHaveBeenCalledTimes(1);
 
-      expect(generatePasswordToClipboard).toBeCalledWith({
+      expect(generatePasswordToClipboard).toHaveBeenCalledWith({
         id: 5,
       });
     });
@@ -208,9 +208,9 @@ describe("ContextMenuClickedHandler", () => {
 
       await sut.run(createData(`${AUTOFILL_ID}_1`, AUTOFILL_ID), { id: 5 } as any);
 
-      expect(autofill).toBeCalledTimes(1);
+      expect(autofill).toHaveBeenCalledTimes(1);
 
-      expect(autofill).toBeCalledWith({ id: 5 }, cipher);
+      expect(autofill).toHaveBeenCalledWith({ id: 5 }, cipher);
     });
 
     it("copies username to clipboard", async () => {
@@ -222,7 +222,7 @@ describe("ContextMenuClickedHandler", () => {
         url: "https://test.com",
       } as any);
 
-      expect(copyToClipboard).toBeCalledTimes(1);
+      expect(copyToClipboard).toHaveBeenCalledTimes(1);
 
       expect(copyToClipboard).toHaveBeenCalledWith({
         text: "TEST_USERNAME",
@@ -239,7 +239,7 @@ describe("ContextMenuClickedHandler", () => {
         url: "https://test.com",
       } as any);
 
-      expect(copyToClipboard).toBeCalledTimes(1);
+      expect(copyToClipboard).toHaveBeenCalledTimes(1);
 
       expect(copyToClipboard).toHaveBeenCalledWith({
         text: "TEST_PASSWORD",

apps/browser/src/autofill/content/autofill-init.spec.ts

@@ -248,7 +248,7 @@ describe("AutofillInit", () => {
           await flushPromises();
 
           expect(autofillInit["collectAutofillContentService"].getPageDetails).toHaveBeenCalled();
-          expect(sendResponse).toBeCalledWith(pageDetails);
+          expect(sendResponse).toHaveBeenCalledWith(pageDetails);
           expect(chrome.runtime.sendMessage).not.toHaveBeenCalledWith({
             command: "collectPageDetailsResponse",
             tab: message.tab,

apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.spec.ts

@@ -401,7 +401,7 @@ describe("AutofillInlineMenuList", () => {
 
           firstFillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowDown" }));
 
-          expect((secondFillCipherElement as HTMLElement).focus).toBeCalled();
+          expect((secondFillCipherElement as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("directs focus to the first item in the cipher list if no cipher is present after the current one when pressing ArrowDown and no new item button exists", () => {
@@ -415,7 +415,7 @@ describe("AutofillInlineMenuList", () => {
 
           lastFillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowDown" }));
 
-          expect((firstFillCipherElement as HTMLElement).focus).toBeCalled();
+          expect((firstFillCipherElement as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("directs focus to the new item button if no cipher is present after the current one when pressing ArrowDown", async () => {
@@ -435,7 +435,7 @@ describe("AutofillInlineMenuList", () => {
 
           lastFillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowDown" }));
 
-          expect(autofillInlineMenuList["newItemButtonElement"].focus).toBeCalled();
+          expect(autofillInlineMenuList["newItemButtonElement"].focus).toHaveBeenCalled();
         });
 
         it("allows the user to move keyboard focus to the previous cipher element on ArrowUp", () => {
@@ -449,7 +449,7 @@ describe("AutofillInlineMenuList", () => {
 
           secondFillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowUp" }));
 
-          expect((firstFillCipherElement as HTMLElement).focus).toBeCalled();
+          expect((firstFillCipherElement as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("directs focus to the last item in the cipher list if no cipher is present before the current one when pressing ArrowUp", () => {
@@ -463,7 +463,7 @@ describe("AutofillInlineMenuList", () => {
 
           firstFillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowUp" }));
 
-          expect((lastFillCipherElement as HTMLElement).focus).toBeCalled();
+          expect((lastFillCipherElement as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("directs focus to the new item button if no cipher is present before the current one when pressing ArrowUp", async () => {
@@ -483,7 +483,7 @@ describe("AutofillInlineMenuList", () => {
 
           firstFillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowUp" }));
 
-          expect(autofillInlineMenuList["newItemButtonElement"].focus).toBeCalled();
+          expect(autofillInlineMenuList["newItemButtonElement"].focus).toHaveBeenCalled();
         });
 
         it("allows the user to move keyboard focus to the view cipher button on ArrowRight", () => {
@@ -495,7 +495,7 @@ describe("AutofillInlineMenuList", () => {
 
           fillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowRight" }));
 
-          expect((viewCipherButton as HTMLElement).focus).toBeCalled();
+          expect((viewCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("ignores keyup events that do not include ArrowUp, ArrowDown, or ArrowRight", () => {
@@ -505,7 +505,7 @@ describe("AutofillInlineMenuList", () => {
 
           fillCipherElement.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowLeft" }));
 
-          expect((fillCipherElement as HTMLElement).focus).not.toBeCalled();
+          expect((fillCipherElement as HTMLElement).focus).not.toHaveBeenCalled();
         });
       });
 
@@ -540,7 +540,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowLeft" }));
 
-          expect((fillCipherButton as HTMLElement).focus).toBeCalled();
+          expect((fillCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("allows the user to move keyboard to the next cipher element on ArrowDown", () => {
@@ -553,7 +553,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowDown" }));
 
-          expect((secondFillCipherButton as HTMLElement).focus).toBeCalled();
+          expect((secondFillCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("allows the user to move keyboard focus to the previous cipher element on ArrowUp", () => {
@@ -566,7 +566,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowUp" }));
 
-          expect((firstFillCipherButton as HTMLElement).focus).toBeCalled();
+          expect((firstFillCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("ignores keyup events that do not include ArrowUp, ArrowDown, or ArrowRight", () => {
@@ -576,7 +576,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowRight" }));
 
-          expect((viewCipherButton as HTMLElement).focus).not.toBeCalled();
+          expect((viewCipherButton as HTMLElement).focus).not.toHaveBeenCalled();
         });
       });
 
@@ -808,7 +808,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowDown" }));
 
-          expect((fillCipherButton as HTMLElement).focus).toBeCalled();
+          expect((fillCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("skips the passkeys heading when the user presses ArrowDown to focus the first list item", () => {
@@ -820,7 +820,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowDown" }));
 
-          expect((fillCipherButton as HTMLElement).focus).toBeCalled();
+          expect((fillCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
 
         it("skips the logins heading when the user presses ArrowUp to focus the previous list item", () => {
@@ -832,7 +832,7 @@ describe("AutofillInlineMenuList", () => {
 
           viewCipherButton.dispatchEvent(new KeyboardEvent("keyup", { code: "ArrowUp" }));
 
-          expect((fillCipherButton as HTMLElement).focus).toBeCalled();
+          expect((fillCipherButton as HTMLElement).focus).toHaveBeenCalled();
         });
       });
     });
@@ -914,7 +914,7 @@ describe("AutofillInlineMenuList", () => {
               new KeyboardEvent("keyup", { code: "ArrowRight" }),
             );
 
-            expect((refreshGeneratedPasswordButton as HTMLElement).focus).toBeCalled();
+            expect((refreshGeneratedPasswordButton as HTMLElement).focus).toHaveBeenCalled();
           });
         });
       });
@@ -984,7 +984,7 @@ describe("AutofillInlineMenuList", () => {
               new KeyboardEvent("keyup", { code: "ArrowLeft" }),
             );
 
-            expect((fillGeneratedPasswordButton as HTMLElement).focus).toBeCalled();
+            expect((fillGeneratedPasswordButton as HTMLElement).focus).toHaveBeenCalled();
           });
         });
       });
@@ -1207,7 +1207,7 @@ describe("AutofillInlineMenuList", () => {
 
         postWindowMessage({ command: "focusAutofillInlineMenuList", token: "test-token" });
 
-        expect((unlockButton as HTMLElement).focus).toBeCalled();
+        expect((unlockButton as HTMLElement).focus).toHaveBeenCalled();
       });
 
       it("focuses the new item button element if the cipher list is empty", async () => {
@@ -1219,7 +1219,7 @@ describe("AutofillInlineMenuList", () => {
 
         postWindowMessage({ command: "focusAutofillInlineMenuList", token: "test-token" });
 
-        expect((newItemButton as HTMLElement).focus).toBeCalled();
+        expect((newItemButton as HTMLElement).focus).toHaveBeenCalled();
       });
 
       it("focuses the first cipher button element if the cipher list is populated", () => {
@@ -1230,7 +1230,7 @@ describe("AutofillInlineMenuList", () => {
 
         postWindowMessage({ command: "focusAutofillInlineMenuList", token: "test-token" });
 
-        expect((firstCipherItem as HTMLElement).focus).toBeCalled();
+        expect((firstCipherItem as HTMLElement).focus).toHaveBeenCalled();
       });
     });