Conversation
Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
… into no-alias-methods
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20187 +/- ##
=======================================
Coverage 46.97% 46.97%
=======================================
Files 3891 3891
Lines 117326 117326
Branches 17942 17942
=======================================
Hits 55118 55118
Misses 59726 59726
Partials 2482 2482 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great job! No new security vulnerabilities introduced in this pull request |
… into no-alias-methods
djsmith85
left a comment
There was a problem hiding this comment.
@cd-bitwarden Thanks for splitting these changes up. Just one minor thing and I'm ready to approve
|
djsmith85
left a comment
There was a problem hiding this comment.
Approving for platform
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
jprusik
left a comment
There was a problem hiding this comment.
Approved for Autofill team concerns




Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled).
🎟️ Tracking
Work to lessen review difficulty of: #19981
📔 Objective
Turn on jest/no-alias-methods and run lint fix, so that we can prevent devs from committed outdated function names, and npm lint fix will auto fix these issues