Skip to content

enable jest/no-alias-methods#20187

Merged
djsmith85 merged 9 commits intomainfrom
no-alias-methods
Apr 16, 2026
Merged

enable jest/no-alias-methods#20187
djsmith85 merged 9 commits intomainfrom
no-alias-methods

Conversation

@cd-bitwarden
Copy link
Copy Markdown
Contributor

@cd-bitwarden cd-bitwarden commented Apr 15, 2026

Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled).

🎟️ Tracking

Work to lessen review difficulty of: #19981

📔 Objective

Turn on jest/no-alias-methods and run lint fix, so that we can prevent devs from committed outdated function names, and npm lint fix will auto fix these issues

cd-bitwarden and others added 4 commits April 15, 2026 12:31
Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Added eslint-plugin-jest with jest/no-alias-methods rule to enforce canonical Jest assertion method names (e.g., toHaveBeenCalled instead of toBeCalled).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.97%. Comparing base (3d2e552) to head (7a91b7c).
⚠️ Report is 27 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20187   +/-   ##
=======================================
  Coverage   46.97%   46.97%           
=======================================
  Files        3891     3891           
  Lines      117326   117326           
  Branches    17942    17942           
=======================================
  Hits        55118    55118           
  Misses      59726    59726           
  Partials     2482     2482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Logo
Checkmarx One – Scan Summary & Details391926b2-bfb0-4498-9ca7-441cb94f0bac

Great job! No new security vulnerabilities introduced in this pull request

@cd-bitwarden cd-bitwarden marked this pull request as ready for review April 16, 2026 01:48
@cd-bitwarden cd-bitwarden requested review from a team as code owners April 16, 2026 01:48
@cd-bitwarden cd-bitwarden requested review from Thomas-Avery, audreyality, dani-garcia, djsmith85 and rr-bw and removed request for dani-garcia and rr-bw April 16, 2026 01:48
Copy link
Copy Markdown
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cd-bitwarden Thanks for splitting these changes up. Just one minor thing and I'm ready to approve

Comment thread apps/web/.claude/.gitignore Outdated
@sonarqubecloud
Copy link
Copy Markdown

@djsmith85 djsmith85 removed the request for review from a team April 16, 2026 12:49
Copy link
Copy Markdown
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for platform

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented Apr 16, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented Apr 16, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

Copy link
Copy Markdown
Contributor

@jprusik jprusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Autofill team concerns

Copy link
Copy Markdown
Contributor

@enmande enmande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auth changes LGTM. Thank you for breaking this change up and getting all tests aligned with primary names 🥇
From Jest docs, these aliases are being removed in v30.

Copy link
Copy Markdown
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KM changes LGTM

@djsmith85 djsmith85 merged commit a5ef326 into main Apr 16, 2026
160 of 162 checks passed
@djsmith85 djsmith85 deleted the no-alias-methods branch April 16, 2026 16:07
@djsmith85 djsmith85 added web cli CLI Application browser Browser Extension desktop Desktop Application t:ci Change Type - Updates to automated workflows labels Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser Browser Extension cli CLI Application desktop Desktop Application t:ci Change Type - Updates to automated workflows web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants