Skip to content

Add style tokens to Feathers Slider#23883

Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom
jordanhalase:feathers_slider_adjust
Apr 19, 2026
Merged

Add style tokens to Feathers Slider#23883
alice-i-cecile merged 7 commits intobevyengine:mainfrom
jordanhalase:feathers_slider_adjust

Conversation

@jordanhalase
Copy link
Copy Markdown
Contributor

Objective

Continuation of #23820, #23830, #23869

This adds style tokens to the slider, and adds Pressed events to do so.

Showcase

No visual change aside from adding hover and pressed style tokens.

Screenshot 2026-04-18 at 8 05 17 PM

@github-actions
Copy link
Copy Markdown
Contributor

Your PR increases Bevy Minimum Supported Rust Version. Please update the rust-version field in the root Cargo.toml file.

@alice-i-cecile alice-i-cecile added this to the 0.19 milestone Apr 19, 2026
@alice-i-cecile alice-i-cecile requested a review from viridia April 19, 2026 01:49
@alice-i-cecile alice-i-cecile added A-UI Graphical user interfaces, styles, layouts, and widgets C-Usability A targeted quality-of-life change that makes Bevy easier to use X-Uncontroversial This work is generally agreed upon D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. labels Apr 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in UI Apr 19, 2026
@alice-i-cecile alice-i-cecile requested a review from kfc35 April 19, 2026 01:49
Copy link
Copy Markdown
Contributor

@kfc35 kfc35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is non blocking and can be done in a follow up if desired and it actually is something that needs to be changed

Comment thread crates/bevy_feathers/src/controls/slider.rs Outdated
@kfc35 kfc35 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Apr 19, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 19, 2026
Merged via the queue into bevyengine:main with commit 6b2ce7c Apr 19, 2026
38 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in UI Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-UI Graphical user interfaces, styles, layouts, and widgets C-Refinement Improves output quality, without fixing a clear bug or adding new functionality. C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants