Use non-srgb main texture to support storage. Fix ClearColor in srgb compositing#23803
Open
beicause wants to merge 1 commit intobevyengine:mainfrom
Open
Use non-srgb main texture to support storage. Fix ClearColor in srgb compositing#23803beicause wants to merge 1 commit intobevyengine:mainfrom
ClearColor in srgb compositing#23803beicause wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
|
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
mnmaita
added
C-Bug
atlv24
reviewed
Apr 14, 2026
| #[default] | ||
| Srgb, | ||
| /// Linear light blending. Physically correct. Requires [`Hdr`]. | ||
| /// Linear light blending. Physically correct. |
Contributor
There was a problem hiding this comment.
Thanks, this also irked me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Our main texture is srgb format, which doesn't support storage usage (in
CameraMainTextureUsages) on some devices and WebGPU.Also the
ClearColoris incorrectly converted to linear color when usingCompositingSpace::SrgbSolution
Always use non-srgb main texture (srgb view is not needed).
As intermediate texture, whether it is srgb or not doesn’t matter and makes no difference during rendering and sampling, unless you copy it to a buffer or retrieve the data. But I believe nowhere does that. The screenshot plugin copies render target instead of main texture.
Testing
Run the code from #9213 (comment)
Details
Before, it's wrong with
CompositingSpace::Srgb:After:
