Skip to content

fix(pcss ex / light despawning): add shadow maps and extracted lights to SyncComponent for lights #23790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kfc35 wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −5
Open

fix(pcss ex / light despawning): add shadow maps and extracted lights to SyncComponent for lights #23790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions crates/bevy_pbr/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ pub mod contact_shadows;
#[cfg(feature = "bevy_gltf")]
mod gltf;
use bevy_light::cluster::GlobalClusterSettings;
use bevy_render::sync_component::SyncComponent;
use bevy_render::{
sync_component::SyncComponent,
view::{RenderExtractedShadowMapVisibleEntities, RenderShadowMapVisibleEntities},
};
pub use contact_shadows::{
ContactShadows, ContactShadowsBuffer, ContactShadowsPlugin, ContactShadowsUniform,
ViewContactShadowsUniformOffset,
Expand Down Expand Up @@ -437,16 +440,31 @@ pub fn stbn_placeholder() -> Image {
}

impl SyncComponent<PbrPlugin> for DirectionalLight {
type Target = Self;
type Target = (
Self,
ExtractedDirectionalLight,
RenderExtractedShadowMapVisibleEntities,
RenderShadowMapVisibleEntities,
);
}
impl SyncComponent<PbrPlugin> for PointLight {
type Target = Self;
type Target = (
Self,
ExtractedPointLight,
RenderExtractedShadowMapVisibleEntities,
RenderShadowMapVisibleEntities,
);
}
impl SyncComponent<PbrPlugin> for SpotLight {
type Target = Self;
type Target = (
Self,
ExtractedPointLight,
RenderExtractedShadowMapVisibleEntities,
RenderShadowMapVisibleEntities,
);
}
impl SyncComponent<PbrPlugin> for RectLight {
type Target = Self;
type Target = (Self, ExtractedRectLight);
}
impl SyncComponent<PbrPlugin> for AmbientLight {
type Target = Self;
Expand Down