Add menu_divider widget.#23788
Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom Apr 14, 2026
Merged
Conversation
kfc35
added
C-Feature
kfc35
approved these changes
Apr 13, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
Looks good to me, also ran and tested it
Just FYI that there are some other minor change for using InputFocusVisible included in this PR which also look good to me as well.
alice-i-cecile
approved these changes
Apr 13, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
Contributor
Author
|
Yeah I added those in because the divider doesn't look so good when there's distracting focus highlights. So they are, in a sense, related :) |
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Contributor
Author
|
@alice-i-cecile I expected a conflict, just pushed a merged version. |
Contributor
|
@viridia looks like you have to resolve conflicts one more time 😅 |
Contributor
Author
|
Yes I was expecting this. |
Contributor
Author
|
Should be good to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Menu dividers have been requested by the editor ui design folks.
Solution
A new
menu_dividerbsn functionTesting
Manual testing
Showcase