Optimize texture attachment access by relaxing atomic memory ordering#23768
Open
CrazyRoka wants to merge 2 commits intobevyengine:mainfrom
Open
Optimize texture attachment access by relaxing atomic memory ordering#23768CrazyRoka wants to merge 2 commits intobevyengine:mainfrom
CrazyRoka wants to merge 2 commits intobevyengine:mainfrom
Conversation
1776de7 to
5667b9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
is_first_callatomic operations fromOrdering::SeqCsttoOrdering::Relaxed.Rationale:
is_first_callis only used to answer a simple question: "Am I the first thread to request this attachment for a render pass?". Because the surrounding data (the texture view, format, clear color) is already fully initialized and completely immutable by the time this is called, there is no dependent memory that requires synchronization. Thefetch_and(false)itself is atomic, meaning it will safely returntrueexactly once, no matter how many threads call it concurrently.Relaxedmemory ordering is correct for given scenario.Testing
cargo bench -p benches --bench render -- texture_attachment