ESD-66431: Fix rich consent signing with Android Keystore keys - #151
Merged
Conversation
arunav-gandhi
self-requested a review
August 27, 2026 07:47
arunav-gandhi
approved these changes
Aug 27, 2026
This was referenced Aug 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix rich-consent DPoP signing for Android Keystore-backed RSA keys
Description
RichConsentsAPIClient casts the enrollment PrivateKey to RSAPrivateKey before signing the DPoP assertion. Android Keystore provides AndroidKeyStoreRSAPrivateKey, which supports signing via JCA Signature but does not implement java.security.interfaces.RSAPrivateKey. This causes Guardian.fetchConsent to crash with a ClassCastException before any network request is sent.
The fix replaces the direct cast and auth0/java-jwt Algorithm.RSA256 usage with a JCA Signature call using the existing PrivateKey abstraction — aligning the implementation with the SDK's allow/reject request path, which already uses SHA256withRSA / PrivateKey directly.
This is the same failure reported in #149.
References
Testing
Unit tests can be run with:
ANDROID_HOME=/path/to/Android/sdk ./gradlew :guardian:testDebugUnitTest
All existing RichConsentsAPIClientTest tests pass. The signing implementation now follows the same SHA256withRSA / PrivateKey approach already used by the SDK's allow/reject request path.
The crash was also reproduced and verified on a real device:
Checklist