Fix rich consent signing with Android Keystore keys - #150
Closed
lucas-heidihealth wants to merge 1 commit into
Closed
Fix rich consent signing with Android Keystore keys#150lucas-heidihealth wants to merge 1 commit into
lucas-heidihealth wants to merge 1 commit into
Conversation
ionutmanolache-okta
marked this pull request as ready for review
August 26, 2026 17:01
anirudh3997
approved these changes
Aug 27, 2026
4 tasks
cgcladeraokta
approved these changes
Aug 27, 2026
cgcladeraokta
left a comment
cgcladeraokta
left a comment
Contributor
There was a problem hiding this comment.
LGTM, tests well 👍
Contributor
|
Merged the changes in #151 as Signatures in this commit and not verified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signaturewith the existingPrivateKeyabstraction instead of casting toRSAPrivateKey.Root cause
RichConsentsAPIClientcasts the enrollmentPrivateKeytoRSAPrivateKeybefore signing. Android Keystore providesAndroidKeyStoreRSAPrivateKey, which can sign throughSignaturebut does not implementjava.security.interfaces.RSAPrivateKey. This causesGuardian.fetchConsentto crash before the request is sent.This is the same failure reported in #149.
Verification
The existing rich-consent client tests pass, and the signing implementation now follows the same
SHA256withRSA/PrivateKeyapproach already used by the SDK's allow/reject request path.