Skip to content

@damassi => Rename NPM package 'Reaction' #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eessex wants to merge 6 commits into from
Closed

@damassi => Rename NPM package 'Reaction' #540

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
723d2cc
change npm name
eessex Feb 21, 2018
0f21fd1
update version
eessex Feb 21, 2018
25a50df
rename to reaction in package-lock
eessex Feb 21, 2018
cd88b81
update version badge
eessex Feb 21, 2018
3c3ecd5
use generic version name
eessex Feb 21, 2018
0f58efd
add yarn version
eessex Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
- **State:** development
- **Demo:** <https://artsy.github.io/reaction>
- **CI:** [![CircleCI](https://circleci.com/gh/artsy/reaction.svg?style=shield)](https://circleci.com/gh/artsy/reaction)
- **NPM:** [![npm version](https://badge.fury.io/js/%40artsy%2Freaction-force.svg)](https://www.npmjs.com/package/@artsy/reaction-force)
- **NPM:** [![npm version](https://badge.fury.io/js/%40artsy%2Freaction.svg)](https://www.npmjs.com/package/@artsy/reaction)
- **Point People:** [@alloy](https://github.com/alloy) & [@l2succes](https://github.com/l2succes)

## Installation
Expand Down
27 changes: 21 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@artsy/reaction-force",
"name": "@artsy/reaction",
"version": "0.0.0-development",
Copy link
Copy Markdown
Contributor

@l2succes l2succes Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eessex I'm a little confused as to where consumers well get the version from if package.json isn't updated with the correct version.

Copy link
Copy Markdown
Contributor

@orta orta Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l2succes the actual version is generated at deploy time using semantic versioning - #521

Copy link
Copy Markdown
Contributor

@l2succes l2succes Feb 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks @orta

"description": "Force’s React Components",
"main": "dist/index.js",
Expand Down Expand Up @@ -186,11 +186,26 @@
"analyzeCommits": {
"preset": "ember",
"releaseRules": [
{"tag": "DOC", "release": "patch"},
{"tag": "FIX", "release": "patch"},
{"tag": "PATCH", "release": "patch"},
{"tag": "FEATURE", "release": "minor"},
{"tag": "BREAKING", "release": "major"}
{
"tag": "DOC",
"release": "patch"
},
{
"tag": "FIX",
"release": "patch"
},
{
"tag": "PATCH",
"release": "patch"
},
{
"tag": "FEATURE",
"release": "minor"
},
{
"tag": "BREAKING",
"release": "major"
}
]
}
}
Expand Down