@damassi => Rename NPM package 'Reaction'#540
Closed
eessex wants to merge 6 commits intoartsy:masterfrom
Closed
Conversation
Contributor
|
LGTM 👍 but seems like a snapshot failure? |
l2succes
reviewed
Feb 21, 2018
| { | ||
| "name": "@artsy/reaction-force", | ||
| "name": "@artsy/reaction", | ||
| "version": "0.0.0-development", |
Contributor
There was a problem hiding this comment.
@eessex I'm a little confused as to where consumers well get the version from if package.json isn't updated with the correct version.
Contributor
Closed
Closed
Contributor
|
Could snapshot names be based off the package.json name? |
Contributor
Author
|
@orta this does seem to be the case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames package to 'reaction' in package.json -- the new version is now published here and up to date with the existing version: https://www.npmjs.com/package/@artsy/reaction
Will update consumers next 🎉
TODO: add 'deprecated' message to reaction-force