Skip to content

HDDS-15451. Fix broken pip install syntax in TestTools.md #10407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amaliujia wants to merge 5 commits into
base: master
Choose a base branch
from
+9 −9
Open

HDDS-15451. Fix broken pip install syntax in TestTools.md #10407

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
633486f
Fix broken pip install syntax in documentation.
amaliujia Jun 2, 2026
4688d06
Patch: have the Chinese documentation be consistent.
amaliujia Jun 2, 2026
1f33c6d
comments: 1. reword sentences for better reader understanding 2. fix…
amaliujia Jun 2, 2026
3799567
Comments: continue improve blockade tests description
amaliujia Jun 2, 2026
16a6723
Comments. 1. Fix type on repeating words. 2. Simplify the example of …
amaliujia Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hadoop-hdds/docs/content/tools/TestTools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Blockade tests are implemented with the help of tests and can be started from th

```
cd blockade
Copy link
Copy Markdown
Contributor

@adoroszlai adoroszlai Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's in tests/blockade.

ozone/hadoop-ozone/dist/dev-support/bin/dist-layout-stitching

Lines 112 to 113 in ba78ed8

# fault injection tests
run cp -r "${ROOT}/hadoop-ozone/fault-injection-test/network-tests/src/test/blockade" tests

Suggested change
cd blockade
cd tests/blockade

Also appears in the sentence above:

ozone/hadoop-hdds/docs/content/tools/TestTools.md

Line 59 in ba78ed8

Blockade tests are implemented with the help of tests and can be started from the `./blockade` directory of the distribution.

Also please consider improving that sentence, I don't think "Blockade tests are implemented with the help of tests" is meaningful.

Copy link
Copy Markdown
Contributor Author

@amaliujia amaliujia Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments addressed.

pip install pytest==2.8.7,blockade
pip install pytest==2.8.7 blockade
python -m pytest -s .
```

Expand Down
2 changes: 1 addition & 1 deletion hadoop-hdds/docs/content/tools/TestTools.zh.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Blockade 测试在其它测试的基础上实现，可以在分发包中的 `./b

```
cd blockade
pip install pytest==2.8.7,blockade
pip install pytest==2.8.7 blockade
python -m pytest -s .
```

Expand Down
Loading