HDDS-15451. Fix broken pip install syntax in TestTools.md#10407
Open
amaliujia wants to merge 4 commits into
Open
HDDS-15451. Fix broken pip install syntax in TestTools.md#10407amaliujia wants to merge 4 commits into
amaliujia wants to merge 4 commits into
Conversation
Contributor
|
@amaliujia could you please create a jira for this PR and mention the jira ID in the PR title as well as in the commit message. Example: #7806 |
Contributor
Author
|
@sreejasahithi thank you and done. |
adoroszlai
reviewed
Jun 2, 2026
Contributor
adoroszlai
left a comment
There was a problem hiding this comment.
Thanks @amaliujia for checking these docs.
| @@ -60,7 +60,7 @@ Blockade tests are implemented with the help of tests and can be started from th | |||
|
|
|||
| ``` | |||
| cd blockade | |||
Contributor
There was a problem hiding this comment.
I think it's in tests/blockade.
ozone/hadoop-ozone/dist/dev-support/bin/dist-layout-stitching
Lines 112 to 113 in ba78ed8
Suggested change
| cd blockade | |
| cd tests/blockade |
Also appears in the sentence above:
Also please consider improving that sentence, I don't think "Blockade tests are implemented with the help of tests" is meaningful.
Contributor
Author
There was a problem hiding this comment.
comments addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Summary
Fix broken pip install syntax in Blockade testing docs
Description
The Blockade section in
hadoop-hdds/docs/content/tools/TestTools.mdshows an invalid pip install command:pip install pytest==2.8.7,blockadeThe comma makes
pip treat pytest==2.8.7,blockadeas a single package name, so the command fails for anyone following the docs.Fix: use space-separated package names:
pip install pytest==2.8.7 blockadeWhat is the link to the Apache JIRA
HDDS-15451
How was this patch tested?
Tested by
hugo serve.