Skip to content

[hotfix][table-runtime] Fix typo in RowTimeMiniBatchAssignerOperator class name #28172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dennis-Mircea wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[hotfix][table-runtime] Fix typo in RowTimeMiniBatchAssignerOperator class name #28172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...va/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecMiniBatchAssigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import org.apache.flink.table.planner.plan.trait.MiniBatchInterval;
import org.apache.flink.table.planner.plan.trait.MiniBatchMode;
import org.apache.flink.table.runtime.operators.wmassigners.ProcTimeMiniBatchAssignerOperator;
import org.apache.flink.table.runtime.operators.wmassigners.RowTimeMiniBatchAssginerOperator;
import org.apache.flink.table.runtime.operators.wmassigners.RowTimeMiniBatchAssignerOperator;
import org.apache.flink.table.runtime.typeutils.InternalTypeInfo;
import org.apache.flink.table.types.logical.RowType;

Expand Down Expand Up @@ -113,7 +113,7 @@ protected Transformation<RowData> translateToPlanInternal(
if (miniBatchInterval.getMode() == MiniBatchMode.ProcTime) {
operator = new ProcTimeMiniBatchAssignerOperator(miniBatchInterval.getInterval());
} else if (miniBatchInterval.getMode() == MiniBatchMode.RowTime) {
operator = new RowTimeMiniBatchAssginerOperator(miniBatchInterval.getInterval());
operator = new RowTimeMiniBatchAssignerOperator(miniBatchInterval.getInterval());
} else {
throw new TableException(
String.format(
Expand Down
2 changes: 1 addition & 1 deletion ...g/apache/flink/table/runtime/operators/wmassigners/ProcTimeMiniBatchAssignerOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*
* <p>NOTE: currently, we use {@link Watermark} to represents the mini-batch marker.
*
* <p>The difference between this operator and {@link RowTimeMiniBatchAssginerOperator} is that,
* <p>The difference between this operator and {@link RowTimeMiniBatchAssignerOperator} is that,
* this operator generates watermarks by itself using processing time, but the other forwards
* watermarks from upstream.
*/
Expand Down
4 changes: 2 additions & 2 deletions ...ers/RowTimeMiniBatchAssginerOperator.java → ...ers/RowTimeMiniBatchAssignerOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
* this operator forwards watermarks from upstream, but the other generates watermarks by itself
* using processing time.
*/
public class RowTimeMiniBatchAssginerOperator extends AbstractStreamOperator<RowData>
public class RowTimeMiniBatchAssignerOperator extends AbstractStreamOperator<RowData>
implements OneInputStreamOperator<RowData, RowData> {

private static final long serialVersionUID = 1L;
Expand All @@ -55,7 +55,7 @@ public class RowTimeMiniBatchAssginerOperator extends AbstractStreamOperator<Row
/** The next watermark to be emitted. */
private transient long nextWatermark;

public RowTimeMiniBatchAssginerOperator(long minibatchInterval) {
public RowTimeMiniBatchAssignerOperator(long minibatchInterval) {
this.minibatchInterval = minibatchInterval;
}

Expand Down
8 changes: 4 additions & 4 deletions ...RowTimeMiniBatchAssginerOperatorTest.java → ...RowTimeMiniBatchAssignerOperatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@

import static org.assertj.core.api.Assertions.assertThat;

/** Tests of {@link RowTimeMiniBatchAssginerOperator}. */
class RowTimeMiniBatchAssginerOperatorTest extends WatermarkAssignerOperatorTestBase {
/** Tests of {@link RowTimeMiniBatchAssignerOperator}. */
class RowTimeMiniBatchAssignerOperatorTest extends WatermarkAssignerOperatorTestBase {

@Test
void testRowTimeWatermarkAssigner() throws Exception {
final RowTimeMiniBatchAssginerOperator operator = new RowTimeMiniBatchAssginerOperator(5);
final RowTimeMiniBatchAssignerOperator operator = new RowTimeMiniBatchAssignerOperator(5);
OneInputStreamOperatorTestHarness<RowData, RowData> testHarness =
new OneInputStreamOperatorTestHarness<>(operator);
testHarness.open();
Expand Down Expand Up @@ -86,7 +86,7 @@ void testRowTimeWatermarkAssigner() throws Exception {

@Test
void testEndWatermarkIsForwarded() throws Exception {
final RowTimeMiniBatchAssginerOperator operator = new RowTimeMiniBatchAssginerOperator(50);
final RowTimeMiniBatchAssignerOperator operator = new RowTimeMiniBatchAssignerOperator(50);
OneInputStreamOperatorTestHarness<RowData, RowData> testHarness =
new OneInputStreamOperatorTestHarness<>(operator);
testHarness.open();
Expand Down