Skip to content

[hotfix][table-runtime] Fix typo in RowTimeMiniBatchAssignerOperator class name#28172

Open
Dennis-Mircea wants to merge 1 commit into
apache:masterfrom
Dennis-Mircea:hotfix/fix-typo-in-row-time-mini-batch-assigner-operator
Open

[hotfix][table-runtime] Fix typo in RowTimeMiniBatchAssignerOperator class name#28172
Dennis-Mircea wants to merge 1 commit into
apache:masterfrom
Dennis-Mircea:hotfix/fix-typo-in-row-time-mini-batch-assigner-operator

Conversation

@Dennis-Mircea
Copy link
Copy Markdown
Contributor

What is the purpose of the change

This pull request fixes a typo in the class name RowTimeMiniBatchAssginerOperator. The class is renamed to RowTimeMiniBatchAssignerOperator (and the corresponding test class to RowTimeMiniBatchAssignerOperatorTest), matching the spelling already used by its sibling ProcTimeMiniBatchAssignerOperator and the surrounding package wmassigners.

The class is @Internal (it is an implementation-side stream operator with no stability annotation, instantiated only by the table planner) and holds no operator/keyed state, so the rename is safe to do directly.

Brief change log

  • Rename RowTimeMiniBatchAssginerOperatorRowTimeMiniBatchAssignerOperator (file, class, and constructor) in flink-table-runtime.
  • Rename the matching test class RowTimeMiniBatchAssginerOperatorTestRowTimeMiniBatchAssignerOperatorTest.
  • Update the only two callers/references: StreamExecMiniBatchAssigner (flink-table-planner) and the {@link ...} reference in the javadoc of ProcTimeMiniBatchAssignerOperator.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

The existing tests in RowTimeMiniBatchAssignerOperatorTest continue to pass under the renamed class:

./mvnw -pl flink-table/flink-table-runtime -Dtest='RowTimeMiniBatchAssignerOperatorTest' test

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no (the class is internal; it has no stability annotation and is only instantiated from StreamExecMiniBatchAssigner)
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no (identifier-only change, no behavior change)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no (the operator carries only transient runtime fields and a final config value, no operator/keyed state)
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 16, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Copy Markdown
Contributor

@spuru9 spuru9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label May 17, 2026
Copy link
Copy Markdown
Contributor

@raminqaf raminqaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@github-actions github-actions Bot added community-reviewed-LGTM Applied if there are 2 non-committer approves on a PR. (The submitter cannot approve their own PR.) and removed community-reviewed PR has been reviewed by the community. community-reviewed-LGTM Applied if there are 2 non-committer approves on a PR. (The submitter cannot approve their own PR.) labels May 20, 2026
Copy link
Copy Markdown
Contributor

@davidradl davidradl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change to the API - can see this in the java docs https://nightlies.apache.org/flink/flink-docs-stable/api/java/overview-tree.html
I suggest you deprecate the existing one and introduce the newly correctly named one. Then there will be no migration impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed-LGTM Applied if there are 2 non-committer approves on a PR. (The submitter cannot approve their own PR.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants