[hotfix][table-runtime] Fix typo in RowTimeMiniBatchAssignerOperator class name#28172
Open
Dennis-Mircea wants to merge 1 commit into
Open
Conversation
Collaborator
raminqaf
approved these changes
May 20, 2026
Contributor
raminqaf
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
davidradl
requested changes
May 21, 2026
Contributor
davidradl
left a comment
There was a problem hiding this comment.
This is a change to the API - can see this in the java docs https://nightlies.apache.org/flink/flink-docs-stable/api/java/overview-tree.html
I suggest you deprecate the existing one and introduce the newly correctly named one. Then there will be no migration impact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request fixes a typo in the class name
RowTimeMiniBatchAssginerOperator. The class is renamed toRowTimeMiniBatchAssignerOperator(and the corresponding test class toRowTimeMiniBatchAssignerOperatorTest), matching the spelling already used by its siblingProcTimeMiniBatchAssignerOperatorand the surrounding packagewmassigners.The class is
@Internal(it is an implementation-side stream operator with no stability annotation, instantiated only by the table planner) and holds no operator/keyed state, so the rename is safe to do directly.Brief change log
RowTimeMiniBatchAssginerOperator→RowTimeMiniBatchAssignerOperator(file, class, and constructor) inflink-table-runtime.RowTimeMiniBatchAssginerOperatorTest→RowTimeMiniBatchAssignerOperatorTest.StreamExecMiniBatchAssigner(flink-table-planner) and the{@link ...}reference in the javadoc ofProcTimeMiniBatchAssignerOperator.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
The existing tests in
RowTimeMiniBatchAssignerOperatorTestcontinue to pass under the renamed class:Does this pull request potentially affect one of the following parts:
@Public(Evolving): no (the class is internal; it has no stability annotation and is only instantiated fromStreamExecMiniBatchAssigner)transientruntime fields and a final config value, no operator/keyed state)Documentation
Was generative AI tooling used to co-author this PR?