Skip to content

[CELEBORN-2328] Auto-apply correctness label from PR template checkbox #3688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
turboFei wants to merge 6 commits into
base: main
Choose a base branch
from
+30 −2
Open

[CELEBORN-2328] Auto-apply correctness label from PR template checkbox #3688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cffefbd
ci: auto-apply correctness label from PR template checkbox
turboFei May 15, 2026
f3793b3
ci: relax Yes checkbox matching to handle whitespace and case variants
turboFei May 15, 2026
9f22507
ci: anchor Yes match to end-of-line to avoid false positives from inl…
turboFei May 15, 2026
f03136e
ci: allow spaces inside checkbox brackets e.g. [ x ]
turboFei May 15, 2026
c9a5600
ci: allow no space between checkbox and Yes e.g. [x]Yes
turboFei May 15, 2026
5c22c58
ci: merge correctness-label workflow into labeler.yml
turboFei May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ Thanks for sending a pull request! Here are some tips for you:

### Does this PR resolve a correctness bug?

<!-- Yes/No. (Note: If yes, committer will add `correctness` label to current pull request). -->
<!-- Check if yes. The `correctness` label will be added/removed automatically. -->
- [ ] Yes

### Does this PR introduce _any_ user-facing change?
Copy link
Copy Markdown
Member

@SteNicholas SteNicholas May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this also use - [ ] Yes. for Does this PR introduce _any_ user-facing change?


Expand Down
29 changes: 28 additions & 1 deletion .github/workflows/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
#
name: Pull Request Labeler
on:
- pull_request_target
pull_request_target:
types: [opened, edited, synchronize, labeled, unlabeled, reopened]

jobs:
labeler:
Expand All @@ -31,3 +32,29 @@ jobs:
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
sync-labels: true

correctness-label:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
steps:
- name: Apply or remove correctness label
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_BODY: ${{ github.event.pull_request.body }}
PR_NUMBER: ${{ github.event.pull_request.number }}
REPO: ${{ github.repository }}
run: |
# Extract only the correctness section (up to the next ### heading).
# PR_BODY is passed via env so it never touches the shell command string.
section=$(printf '%s' "$PR_BODY" | awk '
/Does this PR resolve a correctness bug/ { found=1 }
found && /^###/ && !/Does this PR resolve/ { exit }
found { print }
')
if printf '%s' "$section" | grep -iqE -- '^\s*-\s*\[\s*[xX]\s*\]\s*yes\s*$'; then
gh pr edit "$PR_NUMBER" --repo "$REPO" --add-label "correctness"
else
gh pr edit "$PR_NUMBER" --repo "$REPO" --remove-label "correctness" 2>/dev/null || true
fi
Loading