[CELEBORN-2328] Auto-apply correctness label from PR template checkbox#3688
Open
turboFei wants to merge 6 commits into
Open
[CELEBORN-2328] Auto-apply correctness label from PR template checkbox#3688turboFei wants to merge 6 commits into
turboFei wants to merge 6 commits into
Conversation
turboFei
changed the title
Replace the free-text Yes/No comment in PULL_REQUEST_TEMPLATE.md with a single checkbox. A new GitHub Actions workflow (correctness-label.yml) triggers on pull_request_target opened/edited/synchronize, parses the correctness section of the PR body, and adds or removes the `correctness` label automatically — no manual committer action needed. test ci: auto-apply correctness label from PR template checkbox (#59) Replace the free-text Yes/No comment in PULL_REQUEST_TEMPLATE.md with a single checkbox. A new GitHub Actions workflow (correctness-label.yml) triggers on pull_request_target opened/edited/synchronize, parses the correctness section of the PR body, and adds or removes the `correctness` label automatically — no manual committer action needed. ci: replace github-script with gh CLI to fix workflow validation error ci: auto-create correctness label if it does not exist Revert "ci: auto-create correctness label if it does not exist" This reverts commit e5bed81.
turboFei
changed the title
turboFei
changed the title
turboFei
changed the title
There was a problem hiding this comment.
Pull request overview
This PR automates management of the correctness label by replacing the PR template’s free-text correctness prompt with a checkbox and adding a workflow that syncs the label from that checkbox.
Changes:
- Adds a
pull_request_targetworkflow to add/remove thecorrectnesslabel based on the PR body checkbox. - Updates the PR template to use a single
- [ ] Yescheckbox for correctness bugs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/correctness-label.yml |
Adds automation for syncing the correctness label from the PR template checkbox. |
.github/PULL_REQUEST_TEMPLATE.md |
Replaces the previous correctness prompt with an actionable checkbox. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Consolidate correctness-label.yml into labeler.yml as a second job to reduce workflow file count and unify the pull_request_target trigger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replace the free-text
Yes/Nocomment under "Does this PR resolve a correctness bug?" with a single checkbox in the PR template. Add a GitHub Actions workflow (correctness-label.yml) that automatically adds or removes thecorrectnesslabel based on whether the box is checked, triggered on every PR open/edit.Why are the changes needed?
Previously the note said "committer will add
correctnesslabel" — a manual step that was easy to miss. This automates it: checking the box applies the label immediately, and unchecking it removes the label, with no committer action required.To track all correctness PR: https://github.com/apache/celeborn/issues?q=label%3Acorrectness
Does this PR resolve a correctness bug?
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI workflow logic verified by code review. End-to-end behavior can be confirmed by opening a test PR against the repo and toggling the checkbox.