Skip to content

Bump rust to 1.94 and nightly to 2026-01-18#11218

Merged
kskalski merged 2 commits intoanza-xyz:masterfrom
kskalski:ks/rust1_94
Mar 18, 2026
Merged

Bump rust to 1.94 and nightly to 2026-01-18#11218
kskalski merged 2 commits intoanza-xyz:masterfrom
kskalski:ks/rust1_94

Conversation

@kskalski
Copy link
Copy Markdown

@kskalski kskalski commented Mar 11, 2026

Problem

New Rust toolchain is available

Summary of Changes

Fixes #11035

@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 11, 2026

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @kskalski.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2026

Codecov Report

❌ Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.2%. Comparing base (4a91f00) to head (e9a043b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #11218     +/-   ##
=========================================
- Coverage    83.2%    83.2%   -0.1%     
=========================================
  Files         841      841             
  Lines      318505   318505             
=========================================
- Hits       265189   265152     -37     
- Misses      53316    53353     +37     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski marked this pull request as ready for review March 18, 2026 11:53
@kskalski kskalski requested review from brooksprumo and steviez March 18, 2026 11:53
Copy link
Copy Markdown

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Process wise, we have historically landed code changes separately from the actual version bump when we can.

Is it correct that the code change here must land in the same commit as the Rust version bump ? Ie, is the code change invalid with Rust 1.93 ?

@kskalski
Copy link
Copy Markdown
Author

Thanks for doing this. Process wise, we have historically landed code changes separately from the actual version bump when we can.

Sure, I'm aming for that whenever possible.

Is it correct that the code change here must land in the same commit as the Rust version bump ? Ie, is the code change invalid with Rust 1.93 ?

Exactly. I cannot remove the unsafe annotation first, since __cpuid is actually unsafe in 1.93, I also cannot keep the unsafe annotation after bump, since it triggers warning about unnecessary unsafe (unsafe was relaxed in rust-lang/stdarch#1935)

Of course the other strategy would be to allow the warning, make the bump, remove the allow... Feels like overdoing it, but maybe that would be preferred.

@kskalski kskalski added this pull request to the merge queue Mar 18, 2026
Merged via the queue into anza-xyz:master with commit aa50424 Mar 18, 2026
61 checks passed
@kskalski kskalski deleted the ks/rust1_94 branch March 18, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Rust to 1.94.0

4 participants