Bump rust to 1.94 and nightly to 2026-01-18#11218
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #11218 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 841 841
Lines 318505 318505
=========================================
- Hits 265189 265152 -37
- Misses 53316 53353 +37 🚀 New features to boost your workflow:
|
steviez
left a comment
There was a problem hiding this comment.
Thanks for doing this. Process wise, we have historically landed code changes separately from the actual version bump when we can.
Is it correct that the code change here must land in the same commit as the Rust version bump ? Ie, is the code change invalid with Rust 1.93 ?
Sure, I'm aming for that whenever possible.
Exactly. I cannot remove the unsafe annotation first, since Of course the other strategy would be to allow the warning, make the bump, remove the allow... Feels like overdoing it, but maybe that would be preferred. |
Problem
New Rust toolchain is available
Summary of Changes
unsafeblock around __cpuid checks (relaxed by Makecpuidsafe and update docs rust-lang/stdarch#1935)Fixes #11035