chore: reformat cargo files to conformant toml syntax#11245
chore: reformat cargo files to conformant toml syntax#11245kskalski merged 1 commit intoanza-xyz:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11245 +/- ##
=========================================
- Coverage 83.2% 83.2% -0.1%
=========================================
Files 841 841
Lines 317938 317938
=========================================
- Hits 264707 264685 -22
- Misses 53231 53253 +22 🚀 New features to boost your workflow:
|
|
While this kinda makes some sense to me, I'm surprised I don't see any code upgrading |
|
Right, at the moment whenever you run sort with newer than typical |
|
yeah, for future reference: the motivation comes from #11218. the latest cargo-sort (v2.1.x) appears to sort more things. this change won't cause any issues for users still on v2.0.x btw |
|
I guess if we want to require the stricter formatting going forward we could pin the newer version in Dockerfile and rebuild even existing images once this PR is merged. If there was a way to ensure non-docker/CI scripts use newer version and also enforce stricter formatting, I would like to include it in this PR, but I guess we don't have the machinery for that and adding one seems out of scope. Regardless of that, if we leave things as is, we will still get stricter formatting as a side effect of switching to Rust 1.94 and anytime new docker images are built. |
|
okay, I just talked with @kskalski. the new plan is that I'll rebuild the rust 1.94 image, which means this PR won't be a blocker 🫡 let's split these two things. |
Problem
Using newer cargo sort forces the syntax in
Cargo.tomlfiles to be normalized.Summary of Changes
Apply re-formatting.