Skip to content

fix(e2e): fix flaky Widget Lab and graph chart tests #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alfredo1996 wants to merge 1 commit into from
Closed

fix(e2e): fix flaky Widget Lab and graph chart tests #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/e2e/charts.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ test.describe("Graph chart visualization", () => {
const preview = getPreview(dialog);
await expect(preview).toBeVisible({ timeout: 15_000 });
await dialog.getByRole("button", { name: "Add Widget" }).click();
await expect(dialog).not.toBeVisible({ timeout: 5_000 });
await expect(dialog).not.toBeVisible({ timeout: 10_000 });

// The graph widget should now be on the dashboard grid
// It should have the toolbar controls visible (not "No graph data")
Expand Down
4 changes: 2 additions & 2 deletions app/src/app/(dashboard)/widget-lab/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function TemplateCard({
size="icon"
className="h-7 w-7 text-muted-foreground hover:text-foreground"
onClick={onEdit}
aria-label="Edit"
aria-label="Edit template"
>
<Pencil className="h-3.5 w-3.5" />
</Button>
Expand All @@ -157,7 +157,7 @@ function TemplateCard({
size="icon"
className="h-7 w-7 text-muted-foreground hover:text-destructive"
onClick={onDelete}
aria-label="Delete"
aria-label="Delete template"
>
<Trash2 className="h-3.5 w-3.5" />
</Button>
Expand Down
Loading