Skip to content

fix(e2e): fix flaky Widget Lab and graph chart tests - #413

Closed
alfredo1996 wants to merge 1 commit into
release/1.1from
fix/e2e-flaky-tests
Closed

fix(e2e): fix flaky Widget Lab and graph chart tests#413
alfredo1996 wants to merge 1 commit into
release/1.1from
fix/e2e-flaky-tests

Conversation

@alfredo1996

@alfredo1996 alfredo1996 commented Apr 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Widget Lab template card buttons had mismatched aria-label values ("Edit"/"Delete") vs E2E selectors ("Edit template"/"Delete template")
  • Graph chart test had a 5s timeout for dialog dismiss that was too short for Radix animation — increased to 10s

Fixes

  • app/src/app/(dashboard)/widget-lab/page.tsx: aria-label="Edit""Edit template", aria-label="Delete""Delete template"
  • app/e2e/charts.spec.ts:578: dialog dismiss timeout 5s → 10s

Test plan

  • E2E shard 1/5: graph chart test should pass
  • E2E shard 5/5: all 3 widget-lab tests should pass

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced accessibility labels on widget template action buttons to provide clearer descriptions for screen reader users.

- Widget Lab: aria-labels "Edit" → "Edit template", "Delete" → "Delete template" to match E2E selectors
- Graph chart: increase dialog dismiss timeout from 5s → 10s for Radix animation timing

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alfredo1996 alfredo1996 added bug Something isn't working pkg:app Next.js application package testing labels Apr 6, 2026
@coderabbitai

coderabbitai Bot commented Apr 6, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Two minor adjustments were made: an e2e test timeout for dialog hiding was increased from 5,000ms to 10,000ms to reduce flakiness, and accessibility labels were clarified in the Widget Lab page for edit and delete template buttons.

Changes

Cohort / File(s) Summary
E2E Test Timeout
app/e2e/charts.spec.ts
Increased dialog hide timeout from 5,000ms to 10,000ms in "graph chart — added widget renders on dashboard" test to reduce flakiness.
Widget Lab Accessibility
app/src/app/(dashboard)/widget-lab/page.tsx
Clarified aria-labels for template action buttons: "Edit template" and "Delete template" replace generic "Edit" and "Delete" labels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: fixing flaky tests in Widget Lab and graph chart E2E tests through aria-label corrections and timeout adjustments.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2e-flaky-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alfredo1996

Copy link
Copy Markdown
Owner Author

Superseded by #414 (combined release 1.1 fixes)

@alfredo1996 alfredo1996 closed this Apr 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@alfredo1996
alfredo1996 deleted the fix/e2e-flaky-tests branch April 7, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pkg:app Next.js application package testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants