fix(e2e): fix flaky Widget Lab and graph chart tests - #413
Conversation
- Widget Lab: aria-labels "Edit" → "Edit template", "Delete" → "Delete template" to match E2E selectors - Graph chart: increase dialog dismiss timeout from 5s → 10s for Radix animation timing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedPull request was closed or merged during review WalkthroughTwo minor adjustments were made: an e2e test timeout for dialog hiding was increased from 5,000ms to 10,000ms to reduce flakiness, and accessibility labels were clarified in the Widget Lab page for edit and delete template buttons. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by #414 (combined release 1.1 fixes) |
|



Summary
aria-labelvalues ("Edit"/"Delete") vs E2E selectors ("Edit template"/"Delete template")Fixes
app/src/app/(dashboard)/widget-lab/page.tsx:aria-label="Edit"→"Edit template",aria-label="Delete"→"Delete template"app/e2e/charts.spec.ts:578: dialog dismiss timeout 5s → 10sTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit