Repository navigation
agentplane: make sampler transactions private to sessionstore - #16228
Open
agentydragon wants to merge 3 commits into
Open
agentydragon wants to merge 3 commits into
agentydragon wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Central sampler currently puts transactional state, Runner effects, provider I/O and RPC admission in one root package. Move its durable state and transactions to
internal/sessionstore, with tests beside the authority they exercise. Drop redundantstore_filename prefixes inside that owner.Provider request preparation now takes a concrete recipe. Projection, freezing, stored bytes and intent insertion still run after the same owner/interrupt/pending checks inside the same transaction; network calls remain in the runtime. Pure tool schemas live in the existing
internal/toolcontract. Retry policy remains runtime-owned, and native-frame classification remains executor-owned.History’s real export/recovery/projection tests use a narrowly visible TESTONLY sampler source rather than importing a private Store or replacing it with a mock. Preserve the live native provider stream fixtures, export/checkpoint assertions, recovery-prefix checks and late-evidence fencing. Adoption tests move with Store. No migration, stored bytes, auth, protocol or lifecycle policy changes; Executor, resident runtime and RPC extraction follow separately.
Validation: Store/root libraries compile; all four affected test/binary build targets passed with keep-going; changed-file and commit hooks passed. Parent review verified all 141 production SQL literals unchanged and all 290 existing sampler test functions retained, checked test registration, the transaction preparation point and History fixture operation order. All four behavioral suites passed: Store, sampler unit (including native frame mapping), real History ingress, and sampler integration. The first integration run exposed a missing exec encoding in the request-read test fixture; setting it to JSON passed the focused rerun. Production behavior was unchanged. Hosted checks track the published head separately.
Proposed, ready successor to #16227 in native stack #16208. Review commit:
6e459ce0f5.