Skip to content

agentplane: make sampler transactions private to sessionstore - #16228

Open
agentydragon wants to merge 3 commits into
codex/agentplane-action-rpc-batch4from
codex/agentplane-sampler-store-batch4
Open

agentydragon wants to merge 3 commits into
codex/agentplane-action-rpc-batch4from
codex/agentplane-sampler-store-batch4

Conversation

@agentydragon

@agentydragon agentydragon commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Central sampler currently puts transactional state, Runner effects, provider I/O and RPC admission in one root package. Move its durable state and transactions to internal/sessionstore, with tests beside the authority they exercise. Drop redundant store_ filename prefixes inside that owner.

Provider request preparation now takes a concrete recipe. Projection, freezing, stored bytes and intent insertion still run after the same owner/interrupt/pending checks inside the same transaction; network calls remain in the runtime. Pure tool schemas live in the existing internal/toolcontract. Retry policy remains runtime-owned, and native-frame classification remains executor-owned.

History’s real export/recovery/projection tests use a narrowly visible TESTONLY sampler source rather than importing a private Store or replacing it with a mock. Preserve the live native provider stream fixtures, export/checkpoint assertions, recovery-prefix checks and late-evidence fencing. Adoption tests move with Store. No migration, stored bytes, auth, protocol or lifecycle policy changes; Executor, resident runtime and RPC extraction follow separately.

Validation: Store/root libraries compile; all four affected test/binary build targets passed with keep-going; changed-file and commit hooks passed. Parent review verified all 141 production SQL literals unchanged and all 290 existing sampler test functions retained, checked test registration, the transaction preparation point and History fixture operation order. All four behavioral suites passed: Store, sampler unit (including native frame mapping), real History ingress, and sampler integration. The first integration run exposed a missing exec encoding in the request-read test fixture; setting it to JSON passed the focused rerun. Production behavior was unchanged. Hosted checks track the published head separately.

Proposed, ready successor to #16227 in native stack #16208. Review commit: 6e459ce0f5.

@agentydragon agentydragon added the proposed Concrete implementation proposed for review; not approved for automatic merge label Nov 13, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposed Concrete implementation proposed for review; not approved for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant