Repository navigation
agentplane: make sampler RPC handlers owner-private - #16229
Open
agentydragon wants to merge 1 commit into
Open
agentydragon wants to merge 1 commit into
agentydragon wants to merge 1 commit into
Conversation
agentydragon
added
the
proposed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Sampler's gRPC implementation and its tests from the service root into
internal/rpc. The command composes the concrete Store, runtime, resolver, settings and wakeup hub; public protobuf contracts remain inapi/.All twelve handlers preserve account/UID authorization, fixed status mapping, transaction-scoped admission, post-commit runtime wakeup, Follow revalidation and provider-request streaming. The request-read integration test uses the real Store and a real prepared request large enough for multiple chunks; it checks exact retained/transmitted bytes and credential redaction, plus cross-account, wrong-session and missing-request denial.
Validation: RPC unit/integration test targets and both command targets compile on RBE; formatting, Gazelle and commit hooks pass. Parent review confirms all 141 production SQL literals and all 290 existing sampler test functions remain, with every tracked sampler test file registered in a go_test. Both RPC behavioral suites pass: unit (4.2s) and real PostgreSQL integration (28.1s). Hosted CI checks the published head separately.
Proposed, ready successor to #16228 in native stack #16208. The Executor extraction is independent after Store; the final resident-runtime move updates RPC's concrete Runtime import without a forwarding package. No auth, protocol, persistence or lifecycle redesign is included.
b3cfd10ca9.