Repository navigation
agentplane: separate App command from HTTP server ownership - #16217
Open
agentydragon wants to merge 1 commit into
Open
agentydragon wants to merge 1 commit into
agentydragon wants to merge 1 commit into
Conversation
agentydragon
added
the
proposed
agentydragon
force-pushed
the
codex/agentplane-app-server-batch4
branch
from
November 13, 2026 12:01
f0fd358 to
dcbee21
Compare
agentydragon
force-pushed
the
codex/agentplane-app-server-batch4
branch
from
November 13, 2026 12:08
dcbee21 to
9d636ab
Compare
Contributor
Visual review for
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The App command currently shares a Go package and directory with HTTP composition and route implementations. Put process startup in
app/cmdand the HTTP server, handlers and their tests inapp/internal/server, with Run and ExportOpenAPI as the two package entry points.Keep signal handling, logging, --migrate-only and --export-openapi modes in the command. Update binary/image/runfile targets, schema export, x_defs, imports and active docs atomically. Preserve route registrations, generated schemas, authentication, settings and serving/draining behavior; no compatibility target or forwarding package remains.
Native stack #16208, above App-private libraries. Focused RBE validation passed 15/15 command/server/API tests (https://app.buildbuddy.io/invocation/52d00cdb-7e5a-4e2a-9bb3-66a89e91c1de), and the App image plus OpenAPI schema built (https://app.buildbuddy.io/invocation/1e865ea2-cba5-4c14-b02b-446e073ec98a). Mandatory hooks passed; hosted CI checks the full integrated head.