Repository navigation
agentplane: clarify sampler content and migration ownership - #16219
Open
agentydragon wants to merge 1 commit into
Open
agentydragon wants to merge 1 commit into
agentydragon wants to merge 1 commit into
Conversation
agentydragon
added
the
proposed
agentydragon
force-pushed
the
codex/agentplane-sampler-leaves-batch4
branch
from
November 13, 2026 12:08
922da60 to
daa539e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sampler’s pure content values currently live under
internal/storage, while SQL migration ownership is mixed into the root service package. Move the content contract tointernal/contentand the unchanged embedded SQL plusUpentry point tocentral_sampler/migrations. Update every importer, test, BUILD, command and specification reference together.The content leaf has no Store dependency. The Goose history table, advisory lock ID, SQL filenames and both SQL byte hashes are unchanged; History’s export integration fixture gets narrowly scoped Bazel access to the migration package. Store/Executor/Runtime transaction boundaries and authentication policy are left for the documented ownership design.
Validation: mandatory commit hooks and the sampler command RBE build passed. Content and History export tests passed in the focused invocation. That invocation failed one existing one-second runtime/backoff case; the unchanged whole sampler target passed on the integrated head in this invocation. No assertion or timeout was changed. Full PR CI remains authoritative for the published head.
Proposed final leaf group above App server PR #16217 in native stack #16208. Review the incremental diff against that parent.