Skip to content

agentplane: place App implementation packages under internal #16216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agentydragon wants to merge 1 commit into from
+127 −127
Open

agentplane: place App implementation packages under internal #16216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions agentplane/app/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ get their Threads once it does.

- `go/`: configuration, Huma REST routes, raw HTTP streams and the service lifecycle. The generated
frontend API comes from `//agentplane/app/go:export_schema_bin`.
- `go/threads/`: operator-owned Thread metadata. Generated Dispatcher HTTP routes own command submissions.
History owns event storage, folding and evidence; `go/historydata/` reads it through gRPC.
- `go/proxy/`: authenticated Electric entity/chunk forwarding with current History projection-epoch checks.
- `internal/threads/`: operator-owned Thread metadata. Generated Dispatcher HTTP routes own command submissions.
History owns event storage, folding and evidence; `internal/historydata/` reads it through gRPC.
- `internal/proxy/`: authenticated Electric entity/chunk forwarding with current History projection-epoch checks.
Native service RPCs use generated app-side HTTP gateways with request-bound credentials.
- `go/auth/` and `go/federation/`: PostgreSQL browser sessions, signed OIDC login and operator token
- `internal/auth/` and `internal/federation/`: PostgreSQL browser sessions, signed OIDC login and operator token
exchange. Logout, expiry and replica notifications end browser streams.
- `go/migrations/` and `runtime.go`: embedded Goose schema and service startup. `runtime.go` uses
- `internal/migrations/` and `runtime.go`: embedded Goose schema and service startup. `runtime.go` uses
the shared `agentplane/postgres/migrate` lifecycle before opening the API.
- `settings.py`, `presets.py`, `action_federation_settings.py`, `oidc.py` and
`sandbox_models.py`: deployment configuration schema used by cdk8s.
Expand Down
68 changes: 34 additions & 34 deletions agentplane/app/go/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,19 +27,19 @@ go_library(
"//agentplane/action_service/api/contracts:operator_action_service_go_proto",
"//agentplane/action_service/api/web_push:web_push_service_go_proto",
"//agentplane/app:app_service_go_proto",
"//agentplane/app/go/auth",
"//agentplane/app/go/bridge",
"//agentplane/app/go/federation",
"//agentplane/app/go/historyclient",
"//agentplane/app/go/historydata",
"//agentplane/app/go/historywatch",
"//agentplane/app/go/httperror",
"//agentplane/app/go/internal/settings",
"//agentplane/app/go/migrations",
"//agentplane/app/go/proxy",
"//agentplane/app/go/sandboxes",
"//agentplane/app/go/status",
"//agentplane/app/go/threads",
"//agentplane/app/internal/auth",
"//agentplane/app/internal/bridge",
"//agentplane/app/internal/federation",
"//agentplane/app/internal/historyclient",
"//agentplane/app/internal/historydata",
"//agentplane/app/internal/historywatch",
"//agentplane/app/internal/httperror",
"//agentplane/app/internal/migrations",
"//agentplane/app/internal/proxy",
"//agentplane/app/internal/sandboxes",
"//agentplane/app/internal/settings",
"//agentplane/app/internal/status",
"//agentplane/app/internal/threads",
"//agentplane/egress/api/admin:egress_admin_go_proto",
"//agentplane/environments/v1:environment_service_go_proto",
"//agentplane/grpc/bearer",
Expand Down Expand Up @@ -107,7 +107,7 @@ go_test(
name = "server_test",
srcs = ["server_test.go"],
embed = [":main_lib"],
deps = ["//agentplane/app/go/auth"],
deps = ["//agentplane/app/internal/auth"],
)

go_test(
Expand All @@ -124,7 +124,7 @@ go_test(
"//agentplane/action_service/api/contracts:action_service_go_proto",
"//agentplane/action_service/api/contracts:operator_action_service_go_proto",
"//agentplane/action_service/api/web_push:web_push_service_go_proto",
"//agentplane/app/go/proxy",
"//agentplane/app/internal/proxy",
"//agentplane/environments/v1:environment_service_go_proto",
"//agentplane/grpc/facade",
"//agentplane/mcp_edge/api/connection:connection_service_go_proto",
Expand All @@ -144,7 +144,7 @@ go_test(
srcs = ["policy_facade_test.go"],
embed = [":main_lib"],
deps = [
"//agentplane/app/go/proxy",
"//agentplane/app/internal/proxy",
"//agentplane/egress/api/admin:egress_admin_go_proto",
"//agentplane/egress/api/rules:egress_rules_go_proto",
"//agentplane/grpc/facade",
Expand All @@ -169,7 +169,7 @@ go_test(
srcs = ["runnerapi_test.go"],
embed = [":main_lib"],
deps = [
"//agentplane/app/go/auth",
"//agentplane/app/internal/auth",
"//agentplane/proto:session_go_proto",
"@io_k8s_api//authentication/v1:authentication",
"@io_k8s_apimachinery//pkg/apis/meta/v1:meta",
Expand All @@ -183,8 +183,8 @@ go_test(
srcs = ["appconfigapi_test.go"],
embed = [":main_lib"],
deps = [
"//agentplane/app/go/auth",
"//agentplane/app/go/internal/settings",
"//agentplane/app/internal/auth",
"//agentplane/app/internal/settings",
"//agentplane/sandboxes/runtimeconfig",
"@io_k8s_api//authentication/v1:authentication",
"@io_k8s_apimachinery//pkg/apis/meta/v1:meta",
Expand All @@ -196,8 +196,8 @@ go_test(
srcs = ["statusapi_test.go"],
embed = [":main_lib"],
deps = [
"//agentplane/app/go/auth",
"//agentplane/app/go/status",
"//agentplane/app/internal/auth",
"//agentplane/app/internal/status",
"@io_k8s_api//authentication/v1:authentication",
"@io_k8s_apimachinery//pkg/apis/meta/v1:meta",
],
Expand All @@ -219,11 +219,11 @@ go_test(
embed = [":main_lib"],
deps = [
"//agentplane/app:app_service_go_proto",
"//agentplane/app/go/auth",
"//agentplane/app/go/bridge",
"//agentplane/app/go/internal/settings",
"//agentplane/app/go/sandboxes",
"//agentplane/app/go/threads",
"//agentplane/app/internal/auth",
"//agentplane/app/internal/bridge",
"//agentplane/app/internal/sandboxes",
"//agentplane/app/internal/settings",
"//agentplane/app/internal/threads",
"//agentplane/environments/v1:environment_service_go_proto",
"//agentplane/proto:identity_go_proto",
"//agentplane/proto:session_go_proto",
Expand Down Expand Up @@ -253,7 +253,7 @@ go_test(
embed = [":main_lib"],
deps = [
"//agentplane/action_service/api/contracts:linkage_service_go_proto",
"//agentplane/app/go/auth",
"//agentplane/app/internal/auth",
"//agentplane/proto:identity_go_proto",
"@io_k8s_apimachinery//pkg/apis/meta/v1:meta",
"@io_k8s_apimachinery//pkg/runtime",
Expand All @@ -274,8 +274,8 @@ go_test(
embed = [":main_lib"],
deps = [
"//agentplane/app:app_service_go_proto",
"//agentplane/app/go/auth",
"//agentplane/app/go/threads",
"//agentplane/app/internal/auth",
"//agentplane/app/internal/threads",
"//agentplane/environments/v1:environment_service_go_proto",
"//agentplane/history_service/api/history:history_service_go_proto",
"//agentplane/proto:event_go_proto",
Expand All @@ -296,10 +296,10 @@ go_test(
srcs = ["streamapi_test.go"],
embed = [":main_lib"],
deps = [
"//agentplane/app/go/auth",
"//agentplane/app/go/proxy",
"//agentplane/app/go/sandboxes",
"//agentplane/app/go/threads",
"//agentplane/app/internal/auth",
"//agentplane/app/internal/proxy",
"//agentplane/app/internal/sandboxes",
"//agentplane/app/internal/threads",
"//agentplane/egress/api/admin:egress_admin_go_proto",
"//agentplane/environments/v1:environment_service_go_proto",
"//agentplane/grpc/facade",
Expand Down Expand Up @@ -330,7 +330,7 @@ go_test(
embed = [":main_lib"],
x_defs = {"github.com/agentydragon/ducktape/agentplane/app/go.stagingConfigRlocation": "$(rlocationpath //cluster/k8s/agentplane-staging:agentplane-staging.k8s.yaml)"},
deps = [
"//agentplane/app/go/internal/settings",
"//agentplane/app/internal/settings",
"@in_gopkg_yaml_v3//:yaml_v3",
"@io_bazel_rules_go//go/runfiles",
],
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/action_facade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
actionpb "github.com/agentydragon/ducktape/agentplane/action_service/api/contracts/action_servicepb"
operatoractionpb "github.com/agentydragon/ducktape/agentplane/action_service/api/contracts/operator_action_servicepb"
webpushpb "github.com/agentydragon/ducktape/agentplane/action_service/api/web_push/web_push_servicepb"
"github.com/agentydragon/ducktape/agentplane/app/go/proxy"
"github.com/agentydragon/ducktape/agentplane/app/internal/proxy"
environmentpb "github.com/agentydragon/ducktape/agentplane/environments/v1"
"github.com/agentydragon/ducktape/agentplane/grpc/facade"
connectionpb "github.com/agentydragon/ducktape/agentplane/mcp_edge/api/connection/connection_servicepb"
Expand Down
4 changes: 2 additions & 2 deletions agentplane/app/go/appconfigapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import (
"reflect"
"testing"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
policypb "github.com/agentydragon/ducktape/agentplane/policy/v1"
"github.com/agentydragon/ducktape/agentplane/sandboxes/runtimeconfig"
"google.golang.org/grpc"
Expand Down
6 changes: 3 additions & 3 deletions agentplane/app/go/appservice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ package main

import (
apppb "github.com/agentydragon/ducktape/agentplane/app/appservicepb"
"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/go/status"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/internal/status"
)

// appService implements the app-owned browser API in process. The HTTP gateway
Expand Down
4 changes: 2 additions & 2 deletions agentplane/app/go/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import (
"strings"
"syscall"

"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/go/migrations"
"github.com/agentydragon/ducktape/agentplane/app/internal/migrations"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
dbmigrate "github.com/agentydragon/ducktape/agentplane/postgres/migrate"
"github.com/go-logr/logr"
"sigs.k8s.io/controller-runtime/pkg/log"
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/policy_facade_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"testing"
"time"

"github.com/agentydragon/ducktape/agentplane/app/go/proxy"
"github.com/agentydragon/ducktape/agentplane/app/internal/proxy"
egresspb "github.com/agentydragon/ducktape/agentplane/egress/api/admin/egress_adminpb"
rulespb "github.com/agentydragon/ducktape/agentplane/egress/api/rules/egress_rulespb"
"github.com/agentydragon/ducktape/agentplane/grpc/facade"
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/policyapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"net/http/httptest"
"testing"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
authenticationv1 "k8s.io/api/authentication/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/runnerapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"log/slog"

apppb "github.com/agentydragon/ducktape/agentplane/app/appservicepb"
"github.com/agentydragon/ducktape/agentplane/app/go/bridge"
"github.com/agentydragon/ducktape/agentplane/app/internal/bridge"
sessionpb "github.com/agentydragon/ducktape/agentplane/proto/session"
gatewayruntime "github.com/grpc-ecosystem/grpc-gateway/v2/runtime"
"google.golang.org/grpc/codes"
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/runnerapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"net/http/httptest"
"testing"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
sessionpb "github.com/agentydragon/ducktape/agentplane/proto/session"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
Expand Down
24 changes: 12 additions & 12 deletions agentplane/app/go/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
"sync"
"time"

"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
"github.com/agentydragon/ducktape/agentplane/net/peertls"

environmentpb "github.com/agentydragon/ducktape/agentplane/environments/v1"
Expand All @@ -22,17 +22,17 @@ import (
"github.com/agentydragon/ducktape/agentplane/action_service/api/contracts/linkage_servicepb"
"github.com/agentydragon/ducktape/agentplane/action_service/api/contracts/operator_action_servicepb"
"github.com/agentydragon/ducktape/agentplane/action_service/api/web_push/web_push_servicepb"
"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/bridge"
"github.com/agentydragon/ducktape/agentplane/app/go/federation"
"github.com/agentydragon/ducktape/agentplane/app/go/historyclient"
"github.com/agentydragon/ducktape/agentplane/app/go/historydata"
"github.com/agentydragon/ducktape/agentplane/app/go/historywatch"
"github.com/agentydragon/ducktape/agentplane/app/go/migrations"
"github.com/agentydragon/ducktape/agentplane/app/go/proxy"
"github.com/agentydragon/ducktape/agentplane/app/go/sandboxes"
"github.com/agentydragon/ducktape/agentplane/app/go/status"
"github.com/agentydragon/ducktape/agentplane/app/go/threads"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/bridge"
"github.com/agentydragon/ducktape/agentplane/app/internal/federation"
"github.com/agentydragon/ducktape/agentplane/app/internal/historyclient"
"github.com/agentydragon/ducktape/agentplane/app/internal/historydata"
"github.com/agentydragon/ducktape/agentplane/app/internal/historywatch"
"github.com/agentydragon/ducktape/agentplane/app/internal/migrations"
"github.com/agentydragon/ducktape/agentplane/app/internal/proxy"
"github.com/agentydragon/ducktape/agentplane/app/internal/sandboxes"
"github.com/agentydragon/ducktape/agentplane/app/internal/status"
"github.com/agentydragon/ducktape/agentplane/app/internal/threads"
"github.com/agentydragon/ducktape/agentplane/egress/api/admin/egress_adminpb"
"github.com/agentydragon/ducktape/agentplane/grpc/bearer"
"github.com/agentydragon/ducktape/agentplane/grpc/facade"
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"sync"
"sync/atomic"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/danielgtaylor/huma/v2"
"github.com/danielgtaylor/huma/v2/adapters/humago"
)
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"net/http/httptest"
"testing"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/danielgtaylor/huma/v2"
)

Expand Down
6 changes: 3 additions & 3 deletions agentplane/app/go/sessionapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ import (
"strings"
"unicode/utf8"

"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
identitypb "github.com/agentydragon/ducktape/agentplane/proto/identity"

"google.golang.org/grpc"

apppb "github.com/agentydragon/ducktape/agentplane/app/appservicepb"
appbridge "github.com/agentydragon/ducktape/agentplane/app/go/bridge"
"github.com/agentydragon/ducktape/agentplane/app/go/sandboxes"
appbridge "github.com/agentydragon/ducktape/agentplane/app/internal/bridge"
"github.com/agentydragon/ducktape/agentplane/app/internal/sandboxes"
environmentpb "github.com/agentydragon/ducktape/agentplane/environments/v1"
"github.com/agentydragon/ducktape/agentplane/observability"
sessionpb "github.com/agentydragon/ducktape/agentplane/proto/session"
Expand Down
10 changes: 5 additions & 5 deletions agentplane/app/go/sessionapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ import (
"strings"
"testing"

"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
identitypb "github.com/agentydragon/ducktape/agentplane/proto/identity"

"google.golang.org/grpc"

apppb "github.com/agentydragon/ducktape/agentplane/app/appservicepb"
"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/bridge"
"github.com/agentydragon/ducktape/agentplane/app/go/sandboxes"
"github.com/agentydragon/ducktape/agentplane/app/go/threads"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/bridge"
"github.com/agentydragon/ducktape/agentplane/app/internal/sandboxes"
"github.com/agentydragon/ducktape/agentplane/app/internal/threads"
environmentpb "github.com/agentydragon/ducktape/agentplane/environments/v1"
sessionpb "github.com/agentydragon/ducktape/agentplane/proto/session"
dispatcherpb "github.com/agentydragon/ducktape/agentplane/runner_gateway/dispatcher/api/session/session_dispatcherpb"
Expand Down
2 changes: 1 addition & 1 deletion agentplane/app/go/staging_config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"strings"
"testing"

"github.com/agentydragon/ducktape/agentplane/app/go/internal/settings"
"github.com/agentydragon/ducktape/agentplane/app/internal/settings"
"github.com/bazelbuild/rules_go/go/runfiles"
"gopkg.in/yaml.v3"
)
Expand Down
4 changes: 2 additions & 2 deletions agentplane/app/go/statusapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ import (
"testing"
"time"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/status"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/status"
authenticationv1 "k8s.io/api/authentication/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)
Expand Down
10 changes: 5 additions & 5 deletions agentplane/app/go/streamapi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import (

identitypb "github.com/agentydragon/ducktape/agentplane/proto/identity"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/federation"
"github.com/agentydragon/ducktape/agentplane/app/go/proxy"
"github.com/agentydragon/ducktape/agentplane/app/go/sandboxes"
"github.com/agentydragon/ducktape/agentplane/app/go/threads"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/federation"
"github.com/agentydragon/ducktape/agentplane/app/internal/proxy"
"github.com/agentydragon/ducktape/agentplane/app/internal/sandboxes"
"github.com/agentydragon/ducktape/agentplane/app/internal/threads"
environmentpb "github.com/agentydragon/ducktape/agentplane/environments/v1"
historypb "github.com/agentydragon/ducktape/agentplane/history_service/api/history/history_servicepb"
"github.com/google/uuid"
Expand Down
6 changes: 3 additions & 3 deletions agentplane/app/go/streamapi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ import (
"testing"
"time"

"github.com/agentydragon/ducktape/agentplane/app/go/auth"
"github.com/agentydragon/ducktape/agentplane/app/go/proxy"
"github.com/agentydragon/ducktape/agentplane/app/go/threads"
"github.com/agentydragon/ducktape/agentplane/app/internal/auth"
"github.com/agentydragon/ducktape/agentplane/app/internal/proxy"
"github.com/agentydragon/ducktape/agentplane/app/internal/threads"
environmentpb "github.com/agentydragon/ducktape/agentplane/environments/v1"
"github.com/agentydragon/ducktape/agentplane/grpc/facade"
historypb "github.com/agentydragon/ducktape/agentplane/history_service/api/history/history_servicepb"
Expand Down
Loading
Loading