Repository navigation
agentplane: place App implementation packages under internal - #16216
Open
agentydragon wants to merge 1 commit into
Open
agentydragon wants to merge 1 commit into
agentydragon wants to merge 1 commit into
Conversation
agentydragon
added
the
proposed
agentydragon
force-pushed
the
codex/agentplane-app-private-batch4
branch
from
November 13, 2026 12:01
b8a8500 to
2cc7b6d
Compare
agentydragon
force-pushed
the
codex/agentplane-app-private-batch4
branch
from
November 13, 2026 12:08
2cc7b6d to
d8eb561
Compare
Contributor
Visual review for
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The App's private Go implementation packages currently sit beneath a language-only
app/gonamespace and most are importable from other components. Move those responsibility packages and settings together underapp/internal: authentication, bridge, federation, History clients/views/watches, HTTP errors, migrations, proxies, Sandbox views, status, threads, and settings.Update Go imports, Bazel visibility/dependencies, embeds, fixtures and documentation in the same layer. Preserve HTTP behavior, session/OIDC authentication, schema bytes, SQL migration contents and runtime configuration. Backend services remain independent of App-owned code. The command and HTTP composition remain in their current location until the next layer.
Native stack #16208, above workloadid. The complete App package/test closure passed 27/27 on RBE (https://app.buildbuddy.io/invocation/fbed4eeb-8d56-4a23-b59e-3184f2cef262); mandatory hooks passed. Hosted CI validates the integrated head.