-
Notifications
You must be signed in to change notification settings - Fork 17
MWPW-192158: Shared item loading layer for bulk publish #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andrei4226
wants to merge
18
commits into
main
Choose a base branch
from
MWPW-192158
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e5b2c4e
MWPW-192158: add item loading utils for bulk publish
7d84094
Merge branch 'main' into MWPW-192158
honstar e447922
MWPW-192158: Add shared selection UI components
0da50f8
MWPW-192158: Fix prettier check
3ef7ffc
MWPW-192158: Refactor the translation area to implement the component…
a1d1a36
Merge branch 'main' into MWPW-192158
Andrei4226 cd487ca
MWPW-192158: Decouple common layer from translation and restore store…
71b55fe
Merge branch 'main' into MWPW-192158
Andrei4226 a443cf6
Resolve conflicts
3937a89
Merge branch 'main' into MWPW-192158
Andrei4226 b27aeed
MWPW-192158: Deduplicate item-loading utilities
b786b32
MWPW-192158: Fix prettier check
1285f6f
Merge branch 'main' into MWPW-192158
Andrei4226 c25b633
MWPW-192158: Rename the translation-items-loader file to items-loader
4a8ed93
Merge branch 'main' into MWPW-192158
Andrei4226 fad2fc4
MWPW-192158: Split the style components between common and translation
124c2d2
Merge branch 'main' into MWPW-192158
yesil 3a56418
Merge branch 'main' into MWPW-192158
3ch023 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...src/translation/mas-items-selector.css.js → ...mmon/components/mas-items-selector.css.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...src/translation/mas-selected-items.css.js → ...mmon/components/mas-selected-items.css.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import Store from '../store.js'; | ||
|
|
||
| let activeItemsSelectionStore = Store.translationProjects; | ||
|
|
||
| export function getItemsSelectionStore() { | ||
| return activeItemsSelectionStore; | ||
| } | ||
|
|
||
| /** | ||
| * @param {typeof Store.translationProjects} slice | ||
| */ | ||
| export function setItemsSelectionStore(slice) { | ||
| activeItemsSelectionStore = slice; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.