MWPW-192158: Shared item loading layer for bulk publish#751
MWPW-192158: Shared item loading layer for bulk publish#751Andrei4226 wants to merge 14 commits intomainfrom
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 87.42% 87.47% +0.04%
==========================================
Files 210 215 +5
Lines 62921 63468 +547
==========================================
+ Hits 55010 55516 +506
- Misses 7911 7952 +41
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…s from the common folder
| return null; | ||
| } | ||
| } | ||
| import Store from '../../store.js'; |
There was a problem hiding this comment.
@Andrei4226 (re-posting on current HEAD since the original thread is now outdated) — thanks for inverting the getDisplayName dependency, that part is great. The file itself wasn't renamed though, and the content is now fully generic (no translation-specific imports left). Could you rename it to something like items-loader.js so the filename matches what it actually does? Otherwise future readers will assume it's still translation-only.
There was a problem hiding this comment.
Fixed.
I missed this renaming, now it’s much clearer.
Resolves https://jira.corp.adobe.com/browse/MWPW-192158
QA Checklist: https://wiki.corp.adobe.com/display/adobedotcom/M@S+Engineering+QA+Use+Cases
Extracts the shared item selection UI and data-loading logic from the Translation area into common/, making it reusable across features (Bulk Publish, Translations etc.). Decouples all UI components from Store.translationProjects via a new getItemsSelectionStore() abstraction.
Adds portable data-loading utils, shared rendering helpers and full unit test coverage.
Please review all functionalities from the "Select Items" section in the Translation area.
Please do the steps below before submitting your PR for a code review or QA
🧪 Nala E2E Tests
Nala tests run automatically when you open this PR.
To run Nala tests again:
run nalalabel to this PR (in the right sidebar)To stop automatic Nala tests:
run nalalabelTest URLs: