Skip to content

feat(spoke): expose ownership interface on TreasurySpoke #1311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alerodriargui wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

feat(spoke): expose ownership interface on TreasurySpoke #1311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/spoke/interfaces/ITreasurySpoke.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,18 @@ pragma solidity ^0.8.0;
/// @title ITreasurySpoke
/// @author Aave Labs
/// @notice Interface for the TreasurySpoke.
interface ITreasurySpoke {
interface IOwnable {
/// @notice Returns the current owner.
function owner() external view returns (address);

/// @notice Transfers ownership to a new owner.
function transferOwnership(address newOwner) external;

/// @notice Renounces ownership of the contract.
function renounceOwnership() external;
}
Comment on lines +7 to +16

interface ITreasurySpoke is IOwnable {
/// @notice Supplies a specified amount of the underlying asset to the specified Hub.
/// @dev The Spoke pulls the underlying asset from the caller, so prior approval is required.
/// @param hub The address of the Hub.
Expand Down
1 change: 1 addition & 0 deletions tests/contracts/treasury-spoke/TreasurySpoke.Upgradeable.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ contract TreasurySpokeUpgradeableTest is Base {

assertEq(_getProxyInitializedVersion(address(proxy)), revision);
assertEq(Ownable2Step(address(proxy)).owner(), TREASURY_ADMIN);
assertEq(ITreasurySpoke(address(proxy)).owner(), TREASURY_ADMIN);
}

function test_proxy_reinitialization_fuzz(uint64 initialRevision) public {
Expand Down