feat(spoke): expose ownership interface on TreasurySpoke#1311
Open
alerodriargui wants to merge 1 commit into
Open
feat(spoke): expose ownership interface on TreasurySpoke#1311alerodriargui wants to merge 1 commit into
alerodriargui wants to merge 1 commit into
Conversation
Add IOwnable to ITreasurySpoke and verify owner() is available through the interface.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the ITreasurySpoke interface to expose ownership methods and adds a regression assertion in the upgradeable proxy test to verify the owner is visible through the ITreasurySpoke type.
Changes:
- Added an
IOwnableinterface and madeITreasurySpokeextend it. - Extended upgradeability tests to assert
owner()via theITreasurySpokeinterface.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/contracts/treasury-spoke/TreasurySpoke.Upgradeable.t.sol | Adds an assertion that owner() is callable through ITreasurySpoke on the proxy. |
| src/spoke/interfaces/ITreasurySpoke.sol | Introduces IOwnable and extends ITreasurySpoke with ownership functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+16
| interface IOwnable { | ||
| /// @notice Returns the current owner. | ||
| function owner() external view returns (address); | ||
|
|
||
| /// @notice Transfers ownership to a new owner. | ||
| function transferOwnership(address newOwner) external; | ||
|
|
||
| /// @notice Renounces ownership of the contract. | ||
| function renounceOwnership() external; | ||
| } |
| function renounceOwnership() external; | ||
| } | ||
|
|
||
| interface ITreasurySpoke is IOwnable { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IOwnable to ITreasurySpoke and verify owner() is available through the interface.
Fixes #1283