fex: UI overlap in attribute editing#9453
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces formatting improvements and a UI change to hide the 'Add new attribute' button text when its context menu is open. A logic issue was identified where the menu state resets prematurely when the button is clicked while the menu is already visible, and a code suggestion was provided to handle the toggle correctly.
eliandoran
left a comment
There was a problem hiding this comment.
Hi,
I see you re-formatted the entire file and this makes it really hard to see what actually got changed. Could you please revert the formatting changes so that I can review your PR?
|
@eliandoran , you are absolutely right. I was using Prettier, which automatically formats spacing and commas. I have now reverted those changes, and only the necessary (actual) changes are shown. Kindly review it. |
|
@ZAKIURREHMAN , generally after making the necessary changes, it's a good idea to mark the PR as ready (as I put it in draft when I requested changes). This makes it easy for the maintainer to see which PRs to test and merge. |
Fixed the UI overlap issue for “Add a New Attribute” by managing the menu open/close state with isMenuOpen . #9407