Skip to content

fex: UI overlap in attribute editing#9453

Merged
eliandoran merged 4 commits intoTriliumNext:mainfrom
ZAKIURREHMAN:ui/overlap
Apr 16, 2026
Merged

fex: UI overlap in attribute editing#9453
eliandoran merged 4 commits intoTriliumNext:mainfrom
ZAKIURREHMAN:ui/overlap

Conversation

@ZAKIURREHMAN
Copy link
Copy Markdown
Contributor

Fixed the UI overlap issue for “Add a New Attribute” by managing the menu open/close state with isMenuOpen . #9407

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 16, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces formatting improvements and a UI change to hide the 'Add new attribute' button text when its context menu is open. A logic issue was identified where the menu state resets prematurely when the button is clicked while the menu is already visible, and a code suggestion was provided to handle the toggle correctly.

Comment thread apps/client/src/widgets/ribbon/components/AttributeEditor.tsx Outdated
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 16, 2026
Copy link
Copy Markdown
Contributor

@eliandoran eliandoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I see you re-formatted the entire file and this makes it really hard to see what actually got changed. Could you please revert the formatting changes so that I can review your PR?

@eliandoran eliandoran marked this pull request as draft April 16, 2026 15:05
@ZAKIURREHMAN
Copy link
Copy Markdown
Contributor Author

@eliandoran , you are absolutely right. I was using Prettier, which automatically formats spacing and commas. I have now reverted those changes, and only the necessary (actual) changes are shown. Kindly review it.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 16, 2026
@eliandoran eliandoran added this to the v0.103.0 milestone Apr 16, 2026
@eliandoran eliandoran marked this pull request as ready for review April 16, 2026 18:49
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 16, 2026
@eliandoran eliandoran merged commit 53413be into TriliumNext:main Apr 16, 2026
1 check passed
@eliandoran
Copy link
Copy Markdown
Contributor

@ZAKIURREHMAN , generally after making the necessary changes, it's a good idea to mark the PR as ready (as I put it in draft when I requested changes). This makes it easy for the maintainer to see which PRs to test and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants